Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Request: Control digits after decimal point length #41

Closed
3dsf opened this issue Jan 26, 2024 · 2 comments
Closed

Enhancement Request: Control digits after decimal point length #41

3dsf opened this issue Jan 26, 2024 · 2 comments
Assignees
Labels
done enhancement New feature or request

Comments

@3dsf
Copy link

3dsf commented Jan 26, 2024

Description

Displaying a sensor temp can become distracting when it changes from an integer like display to a float like display and vice-versa. eg// 46°C to 44.4°C

Steps to Reproduce

  1. Enable display of a temp sensor

Screenshots

Screenshot from 2024-01-25 20-08-19
Screenshot from 2024-01-25 20-10-44

Environment

  • Astra Monitor Version: preV8
  • GNOME Version: 46
  • Operating System and Version: Fedora Rawhide (6.8)
  • Other Relevant System Information:

Logs

Additional Context

@ljuzig ljuzig added the enhancement New feature or request label Jan 26, 2024
@ljuzig
Copy link
Collaborator

ljuzig commented Jan 26, 2024

Well, actually we have the settings for the Maximum Number of Figures on almost all values, but not on sensors. The reason is pretty simple: for high integer values like 2500 RPM, we cannot convert them to a decimal format, such as 2.5k. Currently, we try to detect if it's an integer value; otherwise, we format it as a floating-point number. I'm going to add an option to always convert a value to a floating-point format and allow selection of the number of digits to display. This option will be disabled by default.

@ljuzig ljuzig self-assigned this Jan 26, 2024
@ljuzig ljuzig closed this as completed in 5541849 Jan 26, 2024
@ljuzig ljuzig added the done label Jan 26, 2024
@ljuzig
Copy link
Collaborator

ljuzig commented Jan 26, 2024

Done. This will be available in v9.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants