Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After press Backspace key, language settings should not be saved #243

Open
RenBabiuch opened this issue Apr 13, 2024 · 0 comments
Open

After press Backspace key, language settings should not be saved #243

RenBabiuch opened this issue Apr 13, 2024 · 0 comments

Comments

@RenBabiuch
Copy link
Collaborator

RenBabiuch commented Apr 13, 2024

Description:
When the user makes changes to selected/deselected languages of the songs and presses 'Backspace' key (instead of approve choice by yellow confirm button), then the language settings should not be saved - especially if all languages are deselected.

Steps to reproduce:

  1. Enter the game
  2. Choose any input type or skip it
  3. Go to sing a song (user will be automatically taken to select the language of the song first)
  4. Deselect all possible song languages
  5. Press 'Backspace' key
  6. Go back to language settings by clicking: Manage songs -> Select song languages

Expected behaviour:
The 'Backspace' key should ensure that languages selected/deselected by the user are not saved - the default settings should be visible instead (before making any changes). The user shouldn't go to the Song list without pick at least 1 language.

Current behaviour:
The user's language settings are saved, so they can deselect all languages and go to the song list, even if it is not allowed (alert: 'You excluded all the languages, pick at least one')

RenBabiuch added a commit to RenBabiuch/allkaraoke that referenced this issue Apr 16, 2024
@RenBabiuch RenBabiuch changed the title After press Backspace key, changes in Song Languages should not be saved After press Backspace key, language settings should not be saved Apr 21, 2024
Asvarox added a commit that referenced this issue Apr 22, 2024
…ements2

Exclude-languages-test - reproduce the bug #243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant