This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Feature: Can select type of lint message #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,6 +27,9 @@ class LinterJscs extends Linter | |||
| # A string to indicate using jscs config | |||
| config: '' | |||
|
|
|||
| # A string to setup type of message (don't understand why default isn't work) | |||
| defaultLevel: atom.config.get "linter-jscs.messageType" or 'info' | |||
There was a problem hiding this comment.
Use single quotes on "linter-jscs.messageType"
|
Hello @pofigizm Thank's for contribution, after the code style change I'm okay to merge 👍 |
|
Hi, @iam4x. But this file already has mix of quote type. I only copy-paste one string... :) |
|
Yes you must use double quotes when you do string interpolation on Coffee that's why. Thank's merged ;) |
iam4x
pushed a commit
that referenced
this pull request
May 4, 2015
Feature: Can select type of lint message
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my case linter-jscs has most low priority, but it always has error type which has highest priority. I fix it. Now you can chose type of message (priority).