QGC-Gov fixes - std::filesystem support #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll be PR'ing a few changes that we've made in a branch for use with QGC-Gov. We've been using these successfully for several months and had successful flight test events on this code, so I think we're good to get these merged in.
Add a timeout argument to TCPClient
Background -- QGC-Gov uses GStreamer for all our video processing. GStreamer on Android only supports up to NDK v21 (see here). Unfortunately, Android did not support std::filesystem until NDK v22 (see here). Which makes this wholly incompatible. 😢 I have added some defines and removed references to std::filesystem appropriately. Any other modern compiler should pass this check with ease and not have to worry about it. For QGC-Gov, we are able to use native file-handling libraries (wrapped by Qt) to read in the definitions file and pass to libmav using
MessageSet::addFromXMLString().Here, I have conditionally removed references to blocks of code containing std::filesystem.