Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-122218 showing dactivated children #2265

Merged
merged 14 commits into from
Apr 22, 2022
Merged

MAYA-122218 showing dactivated children #2265

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
881c1b3
MAYA-122218 showing dactivated children
pierrebai-adsk Apr 7, 2022
1f19cf7
MAYA122218 update the hiearchy unit test to reflect the current behav…
pierrebai-adsk Apr 7, 2022
6397867
MAYA-122218 made children not return deactivated items
pierrebai-adsk Apr 7, 2022
f5c56a2
MAYA-122218 apply fix to proxy shape
pierrebai-adsk Apr 8, 2022
7cdfefe
MAYA-122218 fix conntext op test in 2022 and earlier
pierrebai-adsk Apr 8, 2022
e4dbc7a
MAYA-122218 implement new hasFilteredChilden from UFE
pierrebai-adsk Apr 14, 2022
ece19c4
MAYA-122218 fix detection of UFe version.
pierrebai-adsk Apr 14, 2022
1e034d1
MAYA-122218 code format
pierrebai-adsk Apr 15, 2022
23de53b
MAYA-122218 simplify code
pierrebai-adsk Apr 19, 2022
ca0eed5
MAYA-122218 fix version checks
pierrebai-adsk Apr 20, 2022
ab3bdb9
MAYA-122218 fix test version check
pierrebai-adsk Apr 20, 2022
ab18f84
MAYA-122218 test correct Maya version. It is all 2023 versions, not j…
pierrebai-adsk Apr 20, 2022
b9e2aa8
MAYA-122218 only use UFE pre-releae version for teh check.
pierrebai-adsk Apr 20, 2022
995a1f4
MAYA-122218 use UFE version env var.
pierrebai-adsk Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/mayaUsd/ufe/UsdHierarchy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,12 +124,14 @@ bool UsdHierarchy::hasChildren() const
//
// I don't have data that proves we need to worry about performance in here,
// so going after maintainability.
return !children().empty();
const bool isFilteringInactive = false;
return !createUFEChildList(getUSDFilteredChildren(fItem), isFilteringInactive).empty();
seando-adsk marked this conversation as resolved.
Show resolved Hide resolved
}

Ufe::SceneItemList UsdHierarchy::children() const
{
return createUFEChildList(getUSDFilteredChildren(fItem), true /*filterInactive*/);
const bool isFilteringInactive = true;
return createUFEChildList(getUSDFilteredChildren(fItem), isFilteringInactive);
}

#ifdef UFE_V2_FEATURES_AVAILABLE
Expand Down
9 changes: 8 additions & 1 deletion test/lib/ufe/testChildFilter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def testFilteredChildren(self):
ball3Prim = mayaUsd.ufe.ufePathToPrim(ball3PathStr)
ball3Prim.SetActive(False)

# Props should now have 5 children and ball3 should not be one of them.
# Props children should have 5 children and ball3 should not be one of them.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove "now". The comment was correct. At line 84 we test that there are 6 children and now we are testing that there are 5.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took multiple passes to update the test and did not realized I dropped a word there.

children = propsHier.children()
self.assertEqual(5, len(children))
self.assertNotIn(ball3Item, children)
Expand All @@ -102,6 +102,13 @@ def testFilteredChildren(self):
usdHierHndlr = ufe.RunTimeMgr.instance().hierarchyHandler(ball3Item.runTimeId())
cf = usdHierHndlr.childFilter()

# Toggle "Inactive Prims" off and get the filtered children
# Props filtered children should have 5 children and ball3 should not be one of them.
cf[0].value = False
children = propsHier.filteredChildren(cf)
self.assertEqual(5, len(children))
self.assertNotIn(ball3Item, children)

# Toggle "Inactive Prims" on and get the filtered children
# (with inactive prims) and verify ball3 is one of them.
cf[0].value = True
Expand Down