Deprecate Jetpack helper and some parts of WPCOM helper #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is part of #1021 |
gravityrail
changed the title
ebinnion
reviewed
May 16, 2018
westonruter
approved these changes
May 18, 2018
|
@gravityrail I just realized that we may have a timing issue with this PR and Jetpack. If AMP 1.0 is released after Jetpack 6.2, is that going to cause a problem? If so, we may want to merge these commits into the 0.7 branch to ensure that it is released before Jetpack. |
|
I've cherry-picked the commits in this branch to 0.7.1: #1170 |
westonruter
added a commit
that referenced
this pull request
Jan 17, 2019
westonruter
added a commit
that referenced
this pull request
Jan 17, 2019
westonruter
added a commit
that referenced
this pull request
Mar 5, 2019
amanintech
pushed a commit
to amanintech/amp-wp
that referenced
this pull request
Oct 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1021
Removes the Jetpack helper after Jetpack version 6.2. Also moves some wpcom-helper functions over to Jetpack, where appropriate.
Once Automattic/jetpack#9458 is merged, this can be merged too, as AMP support will be explicitly included in Jetpack.