Swap join() with implode() (#627)

And correct the order of the params. PHP 7.4 changes the order of the
params for the join() function and implode() is the preferred way to
join an array of strings anyway.

Co-authored-by: Niels Lange <info@nielslange.de>
Co-authored-by: Dat Hoang <htdat@users.noreply.github.com>

Author: 3 people

modules/calendar/calendar.php

@@ -1223,7 +1223,7 @@ function get_calendar_posts_for_week( $args = array(), $context = 'dashboard' )
 				$post_stati = wp_filter_object_list( $post_stati, array( 'name' => 'future' ), 'not' );
 			}
 
-			$args['post_status'] .= join( wp_list_pluck( $post_stati, 'name' ), ',' );
+			$args['post_status'] .= implode( ',', wp_list_pluck( $post_stati, 'name' ) );
 		}
 		// The WP functions for printing the category and author assign a value of 0 to the default
 		// options, but passing this to the query is bad (trashed and auto-draft posts appear!), so

modules/story-budget/story-budget.php

@@ -411,7 +411,7 @@ function get_posts_for_term( $term, $args = null ) {
 				$post_stati = wp_filter_object_list( $post_stati, array( 'name' => 'future' ), 'not' );
 			}
 
-			$args['post_status'] .= join( wp_list_pluck( $post_stati, 'name' ), ',' );
+			$args['post_status'] .= implode( ',', wp_list_pluck( $post_stati, 'name' ) );
 		}
 
 		// Filter by post_author if it's set