Swap join() with implode() #627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And correct the order of the params. PHP 7.4 changes the order of the params for the join() function and implode() is the preferred way to join an array of strings anyway.
Closed
htdat
approved these changes
Apr 12, 2021
Member
htdat
left a comment
htdat
left a comment
There was a problem hiding this comment.
I manually tested before and after this PR with PHP 7.4 and the result looks good.
Before this PR
phpcs -p . --standard=PHPCompatibilityWP --extensions=php --runtime-set testVersion 7.4 --ignore=vendor,node_modules
......................W.W.... 29 / 29 (100%)
FILE: .../edit-flow/modules/calendar/calendar.php
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
1226 | WARNING | Passing the $glue and $pieces parameters in reverse order to join has been deprecated since PHP 7.4; $glue should be the first parameter and $pieces the second
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: .../edit-flow/modules/story-budget/story-budget.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
414 | WARNING | Passing the $glue and $pieces parameters in reverse order to join has been deprecated since PHP 7.4; $glue should be the first parameter and $pieces the second
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Time: 7.79 secs; Memory: 28MB
After applying this PR
➜ edit-flow git:(master) ✗ gh pr checkout 627
M package-lock.json
Switched to a new branch 'update/php74-compat'
➜ edit-flow git:(update/php74-compat) ✗ phpcs -p . --standard=PHPCompatibilityWP --extensions=php --runtime-set testVersion 7.4 --ignore=vendor,node_modules
............................. 29 / 29 (100%)
Time: 7.74 secs; Memory: 28MB
Member
|
@natebot and @mikeyarce - I think it's good to merge this change given that PHP 5.6 to PHP 7.4 tests are all green as shown above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And correct the order of the params. PHP 7.4 changes the order of the params for the join() function and implode() is the preferred way to join an array of strings anyway.
Steps to Test
TODO