Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publicize: Default custom message shows wrong instructions #15115

Closed
kraftbj opened this issue Mar 25, 2020 · 2 comments · Fixed by #15138
Closed

Publicize: Default custom message shows wrong instructions #15115

kraftbj opened this issue Mar 25, 2020 · 2 comments · Fixed by #15138
Assignees
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Publicize Now Jetpack Social, auto-sharing [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended [Type] Good First Bug

Comments

@kraftbj
Copy link
Contributor

kraftbj commented Mar 25, 2020

When using Publicize the custom message box says:

Write a message for your audience here. If you leave this blank, we'll use the post title as the message.

https://github.com/Automattic/jetpack/blob/8.3/extensions/blocks/publicize/form-unwrapped.js#L94

However, when Publicizing a post we use the sub-heading as well as partial body text:

77529234-84772180-6e8f-11ea-9cff-cb6215ed463b

Steps to reproduce the issue

  1. Jetpack + Publicize enabled.
  2. New post in G.
  3. See the Publicize panel.

What I expected

Text to match actual output.

What happened instead

More than just the title was used.

cc: @joendotcom as the original reporter from 2793791-zen

@kraftbj kraftbj added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Publicize Now Jetpack Social, auto-sharing [Type] Good First Bug [Pri] Normal labels Mar 25, 2020
@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" label Mar 25, 2020
@bisko bisko self-assigned this Mar 25, 2020
@bisko
Copy link
Contributor

bisko commented Mar 25, 2020

@kraftbj I'm wondering if the solution should be to change the behavior or update the message in the Publicize block to say:

Write a message for your audience here. If you leave this blank, we'll use part of the post content as the message.

Or something of the sort?

This behavior (to use the post content as the message) has been like this for a while and I've seen customers use it often. I'm not sure if changing the behavior to match the message is a better option than changing the message to reflect the behavior?

@bisko bisko added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Mar 25, 2020
@kraftbj
Copy link
Contributor Author

kraftbj commented Mar 25, 2020

@bisko Yeah, I wouldn't suggest changing behavior, just updating what expectations we're showing.

@kraftbj kraftbj removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Publicize Now Jetpack Social, auto-sharing [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended [Type] Good First Bug
Projects
None yet
3 participants