Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline PDFs: implement AMP support #15192

Closed
jeherve opened this issue Mar 30, 2020 · 0 comments · Fixed by #15196
Closed

Inline PDFs: implement AMP support #15192

jeherve opened this issue Mar 30, 2020 · 0 comments · Fixed by #15196
Assignees
@jeherve
Labels
AMP [Feature] Shortcodes / Embeds [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended

Comments

@jeherve
Copy link
Member

jeherve commented Mar 30, 2020

The new Inline PDFs embed in #14960 does not support AMP.

See #14960 (comment)
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Shortcodes / Embeds [Pri] Normal AMP labels Mar 30, 2020
@jeherve jeherve self-assigned this Mar 30, 2020
@jeherve jeherve mentioned this issue Mar 30, 2020
Merged
jeherve added a commit that referenced this issue Mar 30, 2020
@jeherve
Shortcodes: add support for AMP to Inline PDFs
471829e 
Fixes #15192
@jeherve jeherve mentioned this issue Mar 30, 2020
Merged
jeherve added a commit that referenced this issue Mar 30, 2020
@jeherve @brbrr
Inline PDFs: add support for AMP views (#15196)
60f9105 
* Shortcodes: add support for AMP to Inline PDFs

Fixes #15192

* Add unit test to cover AMP views

* Simplify logic by removing unnecessary else statement

Co-Authored-By: Yaroslav Kukharuk <i.kukharuk@gmail.com>

Co-authored-by: Yaroslav Kukharuk <i.kukharuk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeherve jeherve

Labels
AMP [Feature] Shortcodes / Embeds [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inline PDFs: add support for AMP views Automattic/jetpack
1 participant
@jeherve