Payment Button Block: Toolbar inserter is disabled because there are no child blocks supported

[dpasque]

Impacted plugin

Jetpack

Quick summary

In short: if focus is ever on the Payment Buttons block, the block insterter button in the top toolbar is disabled. This seems to be because there are no child blocks that can be added to the Payment Buttons block (the block inserter sidebar is completely empty).

The consequences of this are...

1. Right after you insert a Payments Button block from the sidebar, you can't close the block inserter sidebar unless you focus elsewhere on the editor.
2. If you have a Payments Button block focused, you can't open the block inserter.

Steps to reproduce

1. Start a page/post
2. Open block inserter sidebar
3. Click on the Payments Button block to insert it.
4. Try to close the block inserter

A clear and concise description of what you expected to happen.

You can -- it's not disabled!

In addition, showing a completely empty block sidebar doesn't seem particularly helpful here... Is there a way to just show all blocks, like we do for other blocks like Paragraph?

What actually happened

The sidebar is empty, the block inserter button disabled.

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

No response

Logs or notes

This seems related to this Gutenberg Bug that was recently fixed: WordPress/gutenberg#43090

But, I'm starting here, because it seems like the core issue is there being no blocks available, which seems like we should be avoiding?

[cuemarie]

📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

• Tested on Simple – Replicated
• Tested on Atomic – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO

• Replicated as described on both Simple and AT

Screenshots/Recordings

Atomic Site

dxDqEI.mp4

Simple Site

VNhio0.mp4

📌 ACTIONS

• Assigned to Other
• CC @jeherve

[worldomonation]

@jeherve FYI the Payments block was partially covered by E2Es in the Calypso repo until this issue. This test case is currently disabled, as you can see here.

In pdWQjU-rL-p2 this feature was noted as Must Cover. Can we get some attention on this issue?

[jeherve]

I believe this is triggered by Core, because the inner block is locked; you cannot remove / replace the button block, it would cause the payment block functionality to break:

Related:

• Payment button: Use block API v2 #25384
• Unable to dismiss block inserter panel after inserting a V2 block WordPress/gutenberg#43090
• Fix clicking on the toggle button not closing the block inserter WordPress/gutenberg#47926

cc'ing @mmtr on this, since he's more familiar with this behavior than I am.

[github-actions]

This issue has been marked as stale. This happened because:

• It has been inactive for the past 6 months.
• It hasn’t been labeled `[Pri] BLOCKER`, `[Pri] High`, `[Type] Feature Request`, `[Type] Enhancement`, `[Type] Janitorial`, `Good For Community`, `[Type] Good First Bug`, etc.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.