Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection banner spacing on wide-screen #8677

Closed
dereksmart opened this issue Jan 30, 2018 · 3 comments
Closed

Connection banner spacing on wide-screen #8677

dereksmart opened this issue Jan 30, 2018 · 3 comments
Assignees
Labels
Connect Flow Connection banners, buttons, ... [Focus] FixTheFlows General [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended

Comments

@dereksmart
Copy link
Member

Spacing of images in connection banner is janky on wide screen. Is there something we can do about this? cc @jeffgolenski maybe?

screen shot 2018-01-30 at 1 09 51 pm

@dereksmart dereksmart added [Focus] FixTheFlows [Type] Bug When a feature is broken and / or not performing as intended labels Feb 23, 2018
@jeherve jeherve added the Connect Flow Connection banners, buttons, ... label Feb 23, 2018
@joanrho joanrho self-assigned this Feb 28, 2018
@jeffgolenski
Copy link
Member

@dereksmart Well, my guess is that the amount of folks who actually see this isn't all too high. The fluidness of the connection banner stays consistent with the rest of the design patterns within /wp-admin/ .

They all pretty much scale infinitely. But if you want to append a max-width: 1200px; or something to the container, feel free. But it may look even weirder with a big empty space to the right of the connection banner on super large screens.

@joanrho
Copy link
Contributor

joanrho commented Feb 28, 2018

hey @dereksmart @rickybanister @jeffgolenski here's a gif mockup of what expanding that container's width could look like (here, set to 1250px). Thoughts?

1250px width of jp connect content container

@MichaelArestad
Copy link
Contributor

I think we should just add a max width to the content inside each tab and center it horizontally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Connect Flow Connection banners, buttons, ... [Focus] FixTheFlows General [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

7 participants