Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Page: cannot disconnect Jetpack from WordPress.com on mobile device #8726

Closed
jeherve opened this issue Feb 2, 2018 · 8 comments · Fixed by #14925
Closed

Admin Page: cannot disconnect Jetpack from WordPress.com on mobile device #8726

jeherve opened this issue Feb 2, 2018 · 8 comments · Fixed by #14925
Labels
Admin Page React-powered dashboard under the Jetpack menu Connect Flow Connection banners, buttons, ... [Focus] FixTheFlows [Pri] High [Type] Bug When a feature is broken and / or not performing as intended

Comments

@jeherve
Copy link
Member

jeherve commented Feb 2, 2018

It isn’t possible to disconnect Jetpack using small screen device. Tested on iPhone SE with Safari. Disconnect modal (with red “Disconnect” button) does not fit into the screen, it isn’t scrollable or zoomable.

https://videopress.com/v/5681LuTP

@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended Admin Page React-powered dashboard under the Jetpack menu [Pri] High labels Feb 2, 2018
@jeherve jeherve added the Connect Flow Connection banners, buttons, ... label Feb 23, 2018
@beaulebens
Copy link
Member

Same as #8744 let's just move the [x] like we did in #8697

@keoshi
Copy link
Contributor

keoshi commented Mar 1, 2018

Works for me, I'm still able to scroll on Chrome, Safari, Firefox. Do you mind retesting, @jeherve or dropping your Safari version here?

@keoshi keoshi self-assigned this Mar 1, 2018
@jeherve
Copy link
Member Author

jeherve commented Mar 2, 2018

Pinging @brbrr since he reported the issue; I don't have an iOS device to test with unfortunately :(

@brbrr
Copy link
Contributor

brbrr commented Mar 2, 2018

I've just re-tested using Safari on iPhone SE / iOS 11.2.6 - issue is still there.

@keoshi what device you were using?

@keoshi
Copy link
Contributor

keoshi commented Mar 5, 2018

@brbrr iPhone X with Chrome and Safari, but I guess it has something to do with the height on the screen.

Even weirder: when tested in emulation mode in desktop it scrolls without a problem. As it should, since we're declaring .dops-modal-wrapper { overflow-y: auto; }.

I wonder if this is overriding the scrolling behavior above:

body.dops-modal-showing {
    overflow: hidden;
}

@brbrr
Copy link
Contributor

brbrr commented Mar 5, 2018

I'm almost 100% sure the issue is reproducible SE screen size/ratio

@keoshi
Copy link
Contributor

keoshi commented Mar 5, 2018

@brbrr I can reproduce the non-scrolling issue, digging a bit more into it. There seems to be something that triggers an overflow: hidden; — another one, not the body.dops-modal-showing above — when the modal comes up.

@keoshi
Copy link
Contributor

keoshi commented Mar 5, 2018

Ok, this is weird. Did more debugging with the iPhone hooked up to the Mac so I could use Safari's inspector and here's what I've done:

  • Removed the modal wrapper and all it's children from the page.
  • Clicked “Manage Connection”, scroll stops working as expected because of body.dops-modal-showing { overflow: hidden; }.
  • Went ahead and deleted that class from the body.
  • Scroll still doesn't work.
  • Starts working again once I click “Manage Connection” a second time (closing the modal if it was still there).

Here's a video:

https://www.youtube.com/watch?v=wuguY-yfivI

I'm at a loss here, since I don't see any more overflow: hidden rules down the cascade.

@Automattic/jetpack is this a behavior of the modal, the button itself, or am I missing something obvious here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu Connect Flow Connection banners, buttons, ... [Focus] FixTheFlows [Pri] High [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants