Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard: do not display tabs to Plans for unconnected users. #13424

Merged
merged 2 commits into from
Sep 20, 2019
Merged

Dashboard: do not display tabs to Plans for unconnected users. #13424

merged 2 commits into from
Sep 20, 2019

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Sep 4, 2019

Fixes #13415

Changes proposed in this Pull Request:

  • When an admin has not linked their account to their wpcom account yet, they will not be able to pick a plan or visit any of the site's pages in Calypso.
    Let's consequently not show them the "My Plan" or "Plans" pages in the Jetpack dashboard.

Testing instructions:

  1. Connect your site to wordpress.com
  2. Create a secondary admin user on the site
  3. Log in as secondary admin in a separate browser/incognito
  4. navigate to the Jetpack dashboard.
  5. You should not see any links to the "My Plan" or "Plans" page in the masthead.

image

Proposed changelog entry for your changes:

  • Dashboard: do not display Plans page to non-connected admins.

@jeherve
Dashboard: do not display tabs to Plans for unconnected users.
2492f2b 
Fixes #13415

When an admin has not linked their account to their wpcom account yet,
they will not be able to pick a plan or visit any of the site's pages in Calypso.
Let's consequently not show them the "My Plan" or "Plans" pages in the Jetpack dashboard.
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. Admin Page React-powered dashboard under the Jetpack menu labels Sep 4, 2019
@jeherve jeherve added this to the 7.8 milestone Sep 4, 2019
@jeherve jeherve requested review from dereksmart and a team September 4, 2019 13:23
@jeherve jeherve self-assigned this Sep 4, 2019
@jetpackbot
Copy link

jetpackbot commented Sep 4, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: October 1, 2019.
Scheduled code freeze: September 24, 2019

Generated by 🚫 dangerJS against f4e6586

@kraftbj kraftbj added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Tests] Needs Tests Some Unit Tests would be really useful to include with this PR. and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 18, 2019
@kraftbj
Copy link
Contributor

kraftbj commented Sep 18, 2019

Tests are failing since they're checking for the tabs removed by this PR.

@jeherve
Copy link
Member Author

jeherve commented Sep 19, 2019

Oops. I had forgotten we even had tests for this part of the dashboard. I updated them.

@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Tests] Needs Tests Some Unit Tests would be really useful to include with this PR. labels Sep 19, 2019
@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 19, 2019
@jeherve jeherve merged commit 7bafce3 into master Sep 20, 2019
@jeherve jeherve deleted the fix/unlinked-user-plans-13415 branch September 20, 2019 07:04
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Sep 20, 2019
jeherve added a commit that referenced this pull request Sep 20, 2019
@jeherve
Changelog: add #13424
8d48e52
jeherve added a commit that referenced this pull request Sep 24, 2019
@jeherve
Changelog: add #13424
be05578
jeherve added a commit that referenced this pull request Sep 24, 2019
@jeherve
Changelog: changes for 7.8 (#13402)
d52a0f3 
* Changelog: initial set of changes for 7.8

* Changelog: add #13310

* Changelog: add #13103

* Changelog: add #13426

* Changelog: add #13389

* Changelog: add #13449

* Changelog: add #13461

* Changelog: add #13460

* Changelog: add #13441

* Changelog: add #13454

* Changelog: add #13457

* Changelog: add #13425

* Changelog: add #13473

* Changelog: add #13355

* Changelog: add #13451

* Changelog: add #13358

* Changelog: add #13464

* Changelog: add #13416

* Changelog: add #13494

* Changelog: add #13465

* Changelog: add #13424

* Changelog: add #13432

* Changelog: add #13471

* Changelog: add 7.7.2 entry

* Changelog: add #13446

* Add more testing elements
jeherve added a commit that referenced this pull request Sep 24, 2019
@jeherve
[not verified] Changelog: changes for 7.8 (#13402)
e50dedc 
* Changelog: initial set of changes for 7.8

* Changelog: add #13310

* Changelog: add #13103

* Changelog: add #13426

* Changelog: add #13389

* Changelog: add #13449

* Changelog: add #13461

* Changelog: add #13460

* Changelog: add #13441

* Changelog: add #13454

* Changelog: add #13457

* Changelog: add #13425

* Changelog: add #13473

* Changelog: add #13355

* Changelog: add #13451

* Changelog: add #13358

* Changelog: add #13464

* Changelog: add #13416

* Changelog: add #13494

* Changelog: add #13465

* Changelog: add #13424

* Changelog: add #13432

* Changelog: add #13471

* Changelog: add 7.7.2 entry

* Changelog: add #13446

* Add more testing elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftbj kraftbj kraftbj approved these changes

@dereksmart dereksmart Awaiting requested review from dereksmart

Assignees

@jeherve jeherve

Labels
Admin Page React-powered dashboard under the Jetpack menu [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
7.8
Development

Successfully merging this pull request may close these issues.

Plans tab is empty as secondary unlinked user
4 participants
@jeherve @jetpackbot @kraftbj @matticbot