Various: Remove pre-PHP 5.6 shims and fallbacks #13465

kraftbj · 2019-09-14T14:44:17Z

With Jetpack's minimum PHP version at 5.6, we can clean up various sections of the codebase that provides shims and fallbacks for older versions.

There are two areas not touched by this PR:

Debugger library -- there is some encryption that should be better tested vs a wide-ranging PR, and the file structure is setup to include a separate 5.3-era file.
Shortcodes -- There is a section where the functionality was designed only with the fallback method, so a replacement should also be better tested.

Changes proposed in this Pull Request:

Use the JETPACK__MINIMUM_PHP_VERSION where it can be.
Clean up MIME detection. mime_content_type was incorrectly marked deprecated at one time, but it hasn't been so in awhile. No need for the finfo handling.
Remove various places where there is a shim/fallback for older PHP verisons.
Deprecate a Photon function that duplicated wp_parse_url.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

If you're an Automattician, include a shortlink to the p2 discussion with Jetpack Product here.

Testing instructions:

Attempt image uploading via the API (e.g. via Calypso)
PHP Unit testing to ensure the Photon tests still work as expected.

Proposed changelog entry for your changes:

Maintenance: Remove outdated pre-PHP 5.6 era code.

jetpackbot · 2019-09-14T14:46:07Z

	Warnings
⚠️	`pre-commit` hook was skipped for one or more commits

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against c935220

jeherve

Just a few quick notes.

_inc/lib/class.media.php

class.json-api-endpoints.php

modules/custom-css/custom-css/preprocessors/lessc.inc.php

functions.photon.php

…waste the effort.

Co-Authored-By: Jeremy Herve <jeremy@jeremy.hu>

jeherve

LGTM! Good idea to create those new functions!

kraftbj · 2019-09-19T14:28:14Z

I'll figure out the Fusion bits today so we can get this landed ASAP before the branch grows stale.

matticbot · 2019-09-19T14:54:40Z

Caution: This PR has changes that must be merged to WordPress.com
Hello kraftbj! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D32920-code before merging this PR. Thank you!

kraftbj · 2019-09-19T17:00:13Z

r196720-wpcom r196721-wpcom r196729-wpcom

* Changelog: initial set of changes for 7.8 * Changelog: add #13310 * Changelog: add #13103 * Changelog: add #13426 * Changelog: add #13389 * Changelog: add #13449 * Changelog: add #13461 * Changelog: add #13460 * Changelog: add #13441 * Changelog: add #13454 * Changelog: add #13457 * Changelog: add #13425 * Changelog: add #13473 * Changelog: add #13355 * Changelog: add #13451 * Changelog: add #13358 * Changelog: add #13464 * Changelog: add #13416 * Changelog: add #13494 * Changelog: add #13465 * Changelog: add #13424 * Changelog: add #13432 * Changelog: add #13471 * Changelog: add 7.7.2 entry * Changelog: add #13446 * Add more testing elements

kraftbj added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial labels Sep 14, 2019

kraftbj requested review from jeherve and a team September 14, 2019 14:44

matticbot added the Touches WP.com Files label Sep 14, 2019

jeherve requested changes Sep 14, 2019

View reviewed changes

jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 14, 2019

jeherve assigned kraftbj Sep 14, 2019

jeherve requested changes Sep 14, 2019

View reviewed changes

functions.photon.php Show resolved Hide resolved

jeherve added this to the 7.8 milestone Sep 14, 2019

This comment has been minimized.

Sign in to view

kraftbj force-pushed the fix/min-php-everywhere branch from bcabe42 to a684c06 Compare September 15, 2019 03:15

kraftbj added [Status] In Progress and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Sep 15, 2019

kraftbj force-pushed the fix/min-php-everywhere branch from a684c06 to 582b890 Compare September 16, 2019 15:58

kraftbj added 13 commits September 16, 2019 12:01

Use minimum PHP version constant

0bd88a5

HTTPS everywhere

2ff9623

Remove PHPCS override needed for PHP 5.2

c86707a

Photon: Remove PHP 5.2 shim

b05b5d2

Simplify MIME type detection in a PHP 5.6+ world

1127dad

Jetpack Provision: Remove pre-PHP 5.3 fallback

faa3402

Remove PHP 5.4 requirement since all of Jetpack is 5.6

cd3fd5b

Remove 5.3 PHP check

6c23bb4

Closures support as of PHP 5.4

f1d383e

[not verified] Signature: Tildes are no longer encoded, so let's not …

10e0f8d

…waste the effort.

Remove PHP 5.4 shim by using Core's

be2c9e5

Add shim for mime_content_type

dd12d98

Remove Vim command. :)

29f2614

kraftbj and others added 4 commits September 16, 2019 12:03

Remove tests for deprecated function.

c7f4cc2

DRY out our mime and sideloading functions

efd4594

class.media.php - PHPCS update.

7b66e8b

Co-Authored-By: Jeremy Herve <jeremy@jeremy.hu>

Add another required PHP extension to composer.json

e9c8a12

kraftbj force-pushed the fix/min-php-everywhere branch from 582b890 to e9c8a12 Compare September 16, 2019 16:04

Merge branch 'master' into fix/min-php-everywhere

c935220

github-actions bot added the [Status] Needs Package Release This PR made changes to a package. Let's update that package now. label Sep 17, 2019

jeherve approved these changes Sep 19, 2019

View reviewed changes

kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! [Status] Tested on WP.com and removed [Status] In Progress labels Sep 19, 2019

kraftbj merged commit a9959f2 into master Sep 19, 2019

kraftbj deleted the fix/min-php-everywhere branch September 19, 2019 17:16

matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Sep 19, 2019

jeherve added [Status] Has Changelog and removed [Status] Needs Changelog labels Sep 20, 2019

jeherve added a commit that referenced this pull request Sep 20, 2019

Changelog: add #13465

8224368

jeherve removed the [Status] Needs Package Release This PR made changes to a package. Let's update that package now. label Sep 20, 2019

jeherve added a commit that referenced this pull request Sep 24, 2019

Changelog: add #13465

48b93e9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Various: Remove pre-PHP 5.6 shims and fallbacks #13465

Various: Remove pre-PHP 5.6 shims and fallbacks #13465

kraftbj commented Sep 14, 2019

jetpackbot commented Sep 14, 2019 •

edited

Loading

jeherve left a comment

This comment has been minimized.

jeherve left a comment

kraftbj commented Sep 19, 2019

matticbot commented Sep 19, 2019

kraftbj commented Sep 19, 2019

Various: Remove pre-PHP 5.6 shims and fallbacks #13465

Various: Remove pre-PHP 5.6 shims and fallbacks #13465

Conversation

kraftbj commented Sep 14, 2019

Changes proposed in this Pull Request:

Is this a new feature or does it add/remove features to an existing part of Jetpack?

Testing instructions:

Proposed changelog entry for your changes:

jetpackbot commented Sep 14, 2019 • edited Loading

jeherve left a comment

Choose a reason for hiding this comment

This comment has been minimized.

jeherve left a comment

Choose a reason for hiding this comment

kraftbj commented Sep 19, 2019

matticbot commented Sep 19, 2019

kraftbj commented Sep 19, 2019

jetpackbot commented Sep 14, 2019 •

edited

Loading