-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search: Add pricing and tier information to Plans page #15125
Merged
gibrown
merged 6 commits into
add/search-plan
from
update/search-plan-api-with-pricing-and-tiers
Mar 27, 2020
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f87eb59
Add handling for pricing and tier APIs
jsnmoon 33e1b3b
Remove tier numbers
jsnmoon 78ec1b8
Add monthly and yearly pricing into search plan
jsnmoon 63a1e0a
Add support for showing ProductSavings component
jsnmoon 6846588
Use site products for pricing and currency code
jsnmoon c863e16
Use a unified loading state for single feature products
jsnmoon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
/** | ||
* External dependencies | ||
*/ | ||
import { useEffect } from 'react'; | ||
import { connect } from 'react-redux'; | ||
|
||
/** | ||
* Internal dependencies | ||
*/ | ||
import { fetchSiteProducts, isFetchingSiteProducts } from 'state/site-products'; | ||
|
||
export function QuerySiteProducts( props ) { | ||
useEffect( () => ! props.isFetchingSiteProducts && props.fetchSiteProducts(), [] ); | ||
return null; | ||
} | ||
|
||
export default connect( | ||
state => ( { isFetchingSiteProducts: isFetchingSiteProducts( state ) } ), | ||
dispatch => ( { fetchSiteProducts: () => dispatch( fetchSiteProducts() ) } ) | ||
)( QuerySiteProducts ); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
_inc/client/plans/single-product-components/product-savings.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
@import 'scss/variables/_colors.scss'; | ||
@import 'scss/calypso-colors.scss'; | ||
|
||
.single-product__savings { | ||
font-style: italic; | ||
} | ||
|
||
.single-product__annual-savings { | ||
&, | ||
.plan-price__integer { | ||
color: $gray-text-min; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
/** | ||
* Internal dependencies | ||
*/ | ||
import { | ||
JETPACK_SITE_PRODUCTS_FETCH, | ||
JETPACK_SITE_PRODUCTS_FETCH_FAIL, | ||
JETPACK_SITE_PRODUCTS_FETCH_RECEIVE, | ||
} from 'state/action-types'; | ||
import restApi from 'rest-api'; | ||
|
||
export const fetchSiteProducts = () => { | ||
return dispatch => { | ||
dispatch( { | ||
type: JETPACK_SITE_PRODUCTS_FETCH, | ||
} ); | ||
return restApi | ||
.fetchSiteProducts() | ||
.then( response => { | ||
dispatch( { | ||
type: JETPACK_SITE_PRODUCTS_FETCH_RECEIVE, | ||
siteProducts: response.data, | ||
} ); | ||
} ) | ||
.catch( error => { | ||
dispatch( { | ||
type: JETPACK_SITE_PRODUCTS_FETCH_FAIL, | ||
error, | ||
} ); | ||
} ); | ||
}; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
export * from './reducer'; | ||
export * from './actions'; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in one of the earlier comments you mentioned this component got slower to load (due to the extra API endpoint)...
I think you can actually eliminate this
products
property from the component (and theisFetchingProducts
property below) and just passsiteProducts
in toSingleProductBackup
instead -- this should work fine since the two have the same structure (and for Jetpack Backup, the exact same data).In that case, you can probably also avoid calling
QueryProducts
on this page entirely, which would avoid having to hit that API endpoint at all.