-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMP: allow the display of the admin bar in AMP views. #15372
Conversation
Fixes #15353 The admin bar can be used in AMP views since AMP 1.3.1, thanks to AMP Dev mode.
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: May 5, 2020. |
jeherve, Your synced wpcom patch D41598-code has been updated. |
e48d012
to
45d7b03
Compare
jeherve, Your synced wpcom patch D41598-code has been updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great now, nicely done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I followed the provided testing instructions, and the admin bar looks good. No validation errors were generated.
I also activated the advanced-ads
plugin and added the example ads to my test site. I’m not sure if that was a sufficient test, but no errors were generated on my test site.
Cherry-picked to |
r205796-wpcom |
Fixes #15353
Changes proposed in this Pull Request:
Is this a new feature or does it add/remove features to an existing part of Jetpack?
Testing instructions:
You should also not see any empty space in the admin bar, where the Likes button previously was.
Alternatively, you can also try to activate and configure an ad on your site using the
advanced-ads
plugin, and make sure no warnings are generated in your error when viewing your site's frontend.Proposed changelog entry for your changes: