-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack: Auto-activate Subscriptions #29028
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run
to get started. More details: p9dueE-5Nn-p2 |
Related:
I would personally vote for keeping this opt-in, to stay consistent with the other Jetpack features that impact the frontend of a site. |
Cool. I just pushed a91df30 to see if I'm doing it properly. Need to wait for a fresh JN to be able to test this change. |
You're right, I meant to add #28288. This was an autocomplete fail on my end, sorry, I tabbed too quick. Noting that we've also been discussing this in Automattic/wp-calypso#71714 |
a91df30
to
4450b8f
Compare
…criptions being auto-activated so to not update the frontend unintentionally
4450b8f
to
0dd60fd
Compare
This PR has been marked as stale. This happened because:
No further action is needed. But it's worth checking if this PR has clear testing instructions, is it up to date with trunk, and it is still valid. Feel free to close this PR if you think it's not valid anymore — if you do, please add a brief explanation. |
This PR has been automatically closed as it has not been updated in some time. If you want to resume work on the PR, feel free to restore the branch and reopen the PR. |
Makes subscriptions enabled by default
I'm still deciding on whether these options should be set to false as they affect the frontend.Already tackled in a91df30Fixes #14621
Proposed changes:
Auto-activate: yes
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No
Testing instructions: