Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack: Auto-activate Subscriptions #29028

Closed
wants to merge 3 commits into from

Conversation

oskosk
Copy link
Contributor

@oskosk oskosk commented Feb 17, 2023

Makes subscriptions enabled by default

I'm still deciding on whether these options should be set to false as they affect the frontend. Already tackled in a91df30

Fixes #14621

Proposed changes:

  • Updates the header of modules/subscriptions.php to have Auto-activate: yes

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Launch a JN site with this branch
  • Create a post
  • Connect Jetpack
  • Attempt to add a Subscrible block. Confirm you can.
  • Visit the frontend sample post and confirm the checkboxes for subscribing are not there
image image
Like this Not like this
  • Visit Jetpack Settings and confirm they're by default like this:

image

@oskosk oskosk added [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Status] In Progress labels Feb 17, 2023
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Feb 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: March 7, 2023.
  • Scheduled code freeze: February 28, 2023.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2023

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack update/jumpstart-subscriptions

to get started. More details: p9dueE-5Nn-p2

@jeherve
Copy link
Member

jeherve commented Feb 17, 2023

Related:

I'm still deciding on whether this options should be set to false as they affect the frontend

I would personally vote for keeping this opt-in, to stay consistent with the other Jetpack features that impact the frontend of a site.

@oskosk
Copy link
Contributor Author

oskosk commented Feb 17, 2023

I would personally vote for keeping this opt-in, to stay consistent with the other Jetpack features that impact the frontend of a site.

Cool. I just pushed a91df30 to see if I'm doing it properly. Need to wait for a fresh JN to be able to test this change.

@oskosk
Copy link
Contributor Author

oskosk commented Feb 17, 2023

@jeherve I think #10903 is not related. The contact form block is already available after connection. Would you mind clarifying in case I'm missing something?

@jeherve
Copy link
Member

jeherve commented Feb 17, 2023

You're right, I meant to add #28288. This was an autocomplete fail on my end, sorry, I tabbed too quick.

Noting that we've also been discussing this in Automattic/wp-calypso#71714

@oskosk oskosk force-pushed the update/jumpstart-subscriptions branch 2 times, most recently from a91df30 to 4450b8f Compare February 17, 2023 17:14
…criptions being auto-activated so to not update the frontend unintentionally
@oskosk oskosk force-pushed the update/jumpstart-subscriptions branch from 4450b8f to 0dd60fd Compare February 17, 2023 17:27
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2023

This PR has been marked as stale. This happened because:

  • It has been inactive in the past 3 months.
  • It hasn’t been labeled `[Pri] BLOCKER`, `[Pri] High`, etc.

No further action is needed. But it's worth checking if this PR has clear testing instructions, is it up to date with trunk, and it is still valid. Feel free to close this PR if you think it's not valid anymore — if you do, please add a brief explanation.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

This PR has been automatically closed as it has not been updated in some time. If you want to resume work on the PR, feel free to restore the branch and reopen the PR.

@github-actions github-actions bot closed this Aug 9, 2023
@github-actions github-actions bot deleted the update/jumpstart-subscriptions branch August 9, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Comments [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress [Status] Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscriptions block: Make it always available
2 participants