Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ESC and clicking background to close full screen dialog #8697

Merged
merged 9 commits into from
Feb 1, 2018
Merged

Enable ESC and clicking background to close full screen dialog #8697

merged 9 commits into from
Feb 1, 2018

Commits on Jan 31, 2018

  1. Enable ESC and clicking background to close full screen dialog

    @gravityrail
    gravityrail committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    3139f1d View commit details
    Browse the repository at this point in the history

  2. Update gridicons and reposition close button on dialog

    @gravityrail
    gravityrail committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    4f125f2 View commit details
    Browse the repository at this point in the history

  3. Better spacing

    @gravityrail
    gravityrail committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    8e13486 View commit details
    Browse the repository at this point in the history

  4. Only import the one gridicon we need

    @gravityrail
    gravityrail committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    1df97fa View commit details
    Browse the repository at this point in the history

  5. Revert unnecessary changes to gridicons

    @gravityrail
    gravityrail committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    3542c33 View commit details
    Browse the repository at this point in the history

  6. Fix JS error due to unbound handler

    @gravityrail
    gravityrail committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    68d0794 View commit details
    Browse the repository at this point in the history

  7. Fix event binding and restrict to ESC code

    @gravityrail
    gravityrail committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    3239f7d View commit details
    Browse the repository at this point in the history

  8. Fix eslint error

    @dereksmart
    dereksmart committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    e4cd4a6 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2018

  1. Removed bind calls from property assignments.

    @zinigor
    zinigor committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    91a2052 View commit details
    Browse the repository at this point in the history