Position Jumpstart dialog close button same as upgrade dialog close button #8961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravityrail
added
[Focus] FixTheFlows
[Status] Needs Design Review
gravityrail
added
the
[Status] Needs Review
|
The new location of the We might want to consider adding an italic link that says 'not right now' below the call to action button for explicitness. I know there's been some debate about redundancy in the past, but when you want a modal to go away I think a 'belt & suspenders' approach makes sense. |
|
Tested and confirmed using https://jurassic.ninja/create?jetpack-beta&nojetpack&branch=fix/jumpstart-dialog-close-button that I can see a dismiss "x" on the jumpstart dialog on mobile.
|
jaswrks
reviewed
Mar 7, 2018
| @@ -163,7 +163,6 @@ function jetpack_get_module_i18n( $key ) { | |||
| 'seo-tools' => array( | |||
| 'name' => _x( 'SEO Tools', 'Module Name', 'jetpack' ), | |||
| 'description' => _x( 'Better results on search engines and social media.', 'Module Description', 'jetpack' ), | |||
| 'recommended description' => _x( 'Better results on search engines and social media.', 'Jumpstart Description', 'jetpack' ), | |||
| top: rem( 100px ); | ||
| opacity: .90; | ||
| } | ||
| } |
jeherve
removed
the
[Status] Needs Review
dereksmart
pushed a commit
that referenced
this pull request
Mar 27, 2018
* Changelog 6.0: create base for changelog. * Add #8938 to changelog * Add #8962 to changelog * Add #8974 to changelog * Add #8975 to changelog * Add #8978 to changelog * Add #8867 to changelog * Add #8937 to changelog * Add #8961 to changelog * Add #8855 to changelog * Add #8944 to changelog * Add #8973 to changelog * Add #8977 to changelog * Add #8979 to changelog * Add #8980 to changelog * Add #8982 to changelog * Add #8983 to changelog * Add #8984 to changelog * Add #8986 to changelog * Add #9005 to changelog * Add #9010 to changelog * Add #9012 to changelog * Add #9021 to changelog * Add #9022 to changelog * Add #9056 to changelog * Add #9061 to changelog * Add #9079 to changelog * Add #9080 to changelog * Add #9088 to changelog * Add #9096 to changelog * Add #9097 to changelog * Add #9100 to changelog * Add #9107 to changelog * Add #8969 to changelog * Add #8993 to changelog * Add #9003 to changelog * Add #9031 to changelog * Add #8945 to changelog * Add #9052 to changelog * Add #9058 to changelog * Add #9066 to changelog * Add #9076 to changelog * Add #9053 to changelog * Add #9108 to changelog * Add #9135 to changelog * Add #9148 to changelog * Add #9125 to changelog * Add #9137 to changelog * Added testing instructions for 6.0. * Added IS testing instructions, huge props to @tiagonoronha. * Added #8498 to changelog. * Added #8954 to changelog. * Added #8985 to changelog. * add #9027 * add #9112 to changelog * add #9136 to changelog * add #9102 to changelog * add #9093 to changelog * add #9062 to changelog * add #9172 to changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7666 and #8744
Changes proposed in this Pull Request:
Important design note
Because this page now reuses the Jetpack Dialogue component that powers other modals, it doesn't have the gap between the top two cards.
This could be implemented by making the Dialogue component transparent, and requiring wrapped components to implement cards where they want translucency. I didn't do this because I wasn't sure if anyone cared either way. Let me know if you need this refinement.
Testing instructions:
wp shelland runJetpack_Options::update_option( 'jumpstart', 'new_connection' )/wp-admin/admin.php?page=jetpack#/jumpstartesc, clicking background, or clicking close button should all close the dialog.Screenshot
Before:
After:
After, mobile (Pixel XL):
Proposed changelog entry for your changes:
Moved the button for closing the Jumpstart modal closer to the dialog so it's more visible.