Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up first pass at user tracks API #9164

Merged
merged 2 commits into from
Mar 27, 2018
Merged

Clean up first pass at user tracks API #9164

merged 2 commits into from
Mar 27, 2018

Conversation

dereksmart
Copy link
Member

@dereksmart dereksmart commented Mar 27, 2018 •
edited
Loading

This reverts all of #9003
And any mention of the old jetpack_event_tracking setting that was registered for our settings API.

Do not merge until the UI has been updated to call the new endpoint in #9156

We're going with a more centralized API merged in #9142

@dereksmart dereksmart added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Focus] GDPR labels Mar 27, 2018
@dereksmart dereksmart requested a review from a team as a code owner March 27, 2018 14:34
jaswrks
jaswrks approved these changes Mar 27, 2018
View reviewed changes
Copy link
Contributor

@jaswrks jaswrks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

This is an important point that was made:

Do not merge until the UI has been updated to call the new endpoint in #9156

@mattwiebe
Copy link
Contributor

I merged #9156 so this is good to go

@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 27, 2018
zinigor
zinigor approved these changes Mar 27, 2018
View reviewed changes
Copy link
Member

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverts the endpoint nicely, thanks!

@zinigor zinigor added this to the 6.0 milestone Mar 27, 2018
@zinigor zinigor merged commit 33b2f8d into master Mar 27, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 27, 2018
@zinigor zinigor deleted the revert/9003 branch March 27, 2018 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaswrks jaswrks jaswrks approved these changes

@zinigor zinigor zinigor approved these changes

@mattwiebe mattwiebe Awaiting requested review from mattwiebe

@oskosk oskosk Awaiting requested review from oskosk

Assignees
No one assigned
Labels
[Focus] GDPR [Type] Janitorial
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dereksmart @mattwiebe @zinigor @jaswrks @matticbot