Merge pull request #13770 from Automattic/vkarpov15/gh-13664-2

fix(model): make Model.bulkWrite() with empty array and ordered false not throw an error
Automattic · Aug 24, 2023 · 4f79ce2 · 4f79ce2
2 parents 0229ffd + 17c31b7
commit 4f79ce2
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 3 deletions.
diff --git a/lib/model.js b/lib/model.js
@@ -3796,6 +3796,10 @@ Model.bulkWrite = function(ops, options, callback) {
     function completeUnorderedValidation() {
       validOps = validOps.sort().map(index => ops[index]);
 
+      if (validOps.length === 0) {
+        return cb(null, getDefaultBulkwriteResult());
+      }
+
       this.$__collection.bulkWrite(validOps, options, (error, res) => {
         if (error) {
           if (validationErrors.length > 0) {

diff --git a/test/model.test.js b/test/model.test.js
@@ -7856,9 +7856,32 @@ describe('Model', function() {
     const userSchema = new Schema({ name: String });
     const User = db.model('User', userSchema);
 
-    const err = await User.bulkWrite([], { ordered: false }).then(() => null, err => err);
-    assert.ok(err);
-    assert.equal(err.name, 'MongoInvalidArgumentError');
+    const res = await User.bulkWrite([], { ordered: false });
+    assert.deepEqual(
+      res,
+      {
+        result: {
+          ok: 1,
+          writeErrors: [],
+          writeConcernErrors: [],
+          insertedIds: [],
+          nInserted: 0,
+          nUpserted: 0,
+          nMatched: 0,
+          nModified: 0,
+          nRemoved: 0,
+          upserted: []
+        },
+        insertedCount: 0,
+        matchedCount: 0,
+        modifiedCount: 0,
+        deletedCount: 0,
+        upsertedCount: 0,
+        upsertedIds: {},
+        insertedIds: {},
+        n: 0
+      }
+    );
   });
 
   it('allows calling `create()` after `bulkWrite()` (gh-9350)', async function() {