fix(document): handle required when schema has property named `isSele…

…cted`

Fix #9438

lib/document.js

@@ -41,6 +41,9 @@ const isMongooseObject = utils.isMongooseObject;
 const arrayAtomicsBackupSymbol = Symbol('mongoose.Array#atomicsBackup');
 const arrayAtomicsSymbol = require('./helpers/symbols').arrayAtomicsSymbol;
 const documentArrayParent = require('./helpers/symbols').documentArrayParent;
+const documentIsSelected = require('./helpers/symbols').documentIsSelected;
+const documentIsModified = require('./helpers/symbols').documentIsModified;
+const documentModifiedPaths = require('./helpers/symbols').documentModifiedPaths;
 const documentSchemaSymbol = require('./helpers/symbols').documentSchemaSymbol;
 const getSymbol = require('./helpers/symbols').getSymbol;
 const populateModelSymbol = require('./helpers/symbols').populateModelSymbol;
@@ -1844,6 +1847,8 @@ Document.prototype.modifiedPaths = function(options) {
   }, []);
 };
 
+Document.prototype[documentModifiedPaths] = Document.prototype.modifiedPaths;
+
 /**
  * Returns true if this document was modified, else false.
  *
@@ -1868,7 +1873,7 @@ Document.prototype.isModified = function(paths, modifiedPaths) {
     if (!Array.isArray(paths)) {
       paths = paths.split(' ');
     }
-    const modified = modifiedPaths || this.modifiedPaths();
+    const modified = modifiedPaths || this[documentModifiedPaths]();
     const directModifiedPaths = Object.keys(this.$__.activePaths.states.modify);
     const isModifiedChild = paths.some(function(path) {
       return !!~modified.indexOf(path);
@@ -1884,6 +1889,8 @@ Document.prototype.isModified = function(paths, modifiedPaths) {
   return this.$__.activePaths.some('modify');
 };
 
+Document.prototype[documentIsModified] = Document.prototype.isModified;
+
 /**
  * Checks if a path is set to its default.
  *
@@ -2040,6 +2047,8 @@ Document.prototype.isSelected = function isSelected(path) {
   return true;
 };
 
+Document.prototype[documentIsSelected] = Document.prototype.isSelected;
+
 /**
  * Checks if `path` was explicitly selected. If no projection, always returns
  * true.

lib/helpers/symbols.js

@@ -5,6 +5,9 @@ exports.arrayParentSymbol = Symbol('mongoose#Array#_parent');
 exports.arrayPathSymbol = Symbol('mongoose#Array#_path');
 exports.arraySchemaSymbol = Symbol('mongoose#Array#_schema');
 exports.documentArrayParent = Symbol('mongoose:documentArrayParent');
+exports.documentIsSelected = Symbol('mongoose#Document#isSelected');
+exports.documentIsModified = Symbol('mongoose#Document#isModified');
+exports.documentModifiedPaths = Symbol('mongoose#Document#modifiedPaths');
 exports.documentSchemaSymbol = Symbol('mongoose#Document#schema');
 exports.getSymbol = Symbol('mongoose#Document#get');
 exports.modelSymbol = Symbol('mongoose#Model');

lib/schematype.js

@@ -16,6 +16,9 @@ const util = require('util');
 const utils = require('./utils');
 const validatorErrorSymbol = require('./helpers/symbols').validatorErrorSymbol;
 
+const documentIsSelected = require('./helpers/symbols').documentIsSelected;
+const documentIsModified = require('./helpers/symbols').documentIsModified;
+
 const CastError = MongooseError.CastError;
 const ValidatorError = MongooseError.ValidatorError;
 
@@ -915,7 +918,7 @@ SchemaType.prototype.required = function(required, message) {
     const cachedRequired = get(this, '$__.cachedRequired');
 
     // no validation when this path wasn't selected in the query.
-    if (cachedRequired != null && !this.isSelected(_this.path) && !this.isModified(_this.path)) {
+    if (cachedRequired != null && !this[documentIsSelected](_this.path) && !this[documentIsModified](_this.path)) {
       return true;
     }