refactor(iframe): manage block attributes from shared json file

src/blocks/iframe/block.json

@@ -0,0 +1,22 @@
+{
+	"name": "iframe",
+	"category": "newspack",
+	"attributes": {
+        "src": {
+			"type": "string",
+			"default": ""
+		},"archiveFolder": {
+			"type": "string",
+			"default": ""
+		},"height": {
+			"type": "string",
+			"default": "600px"
+		},"width": {
+			"type": "string",
+			"default": "100%"
+		},"isFullScreen": {
+			"type": "boolean",
+			"default": false
+		}
+	}
+}

src/blocks/iframe/index.js

@@ -8,23 +8,27 @@ import { __ } from '@wordpress/i18n';
  * Internal dependencies
  */
 import edit from './edit';
+import metadata from './block.json';
+const { name, attributes, category } = metadata;
 
 /**
  * Style dependencies - will load in editor
  */
 import './editor.scss';
 import { iframeIcon } from './icons';
 
-export const name = 'iframe';
 export const title = __( 'Iframe', 'newspack-blocks' );
 
+// Name must be exported separately.
+export { name };
+
 export const settings = {
 	title,
 	icon: {
 		src: iframeIcon,
 		foreground: '#36f',
 	},
-	category: 'newspack',
+	category,
 	keywords: [ __( 'iframe', 'newspack-blocks' ), __( 'project iframe', 'newspack-blocks' ) ],
 	description: (
 		<>
@@ -34,27 +38,7 @@ export const settings = {
 			</ExternalLink>
 		</>
 	),
-	attributes: {
-		src: {
-			type: 'string',
-		},
-		archiveFolder: {
-			type: 'string',
-			default: '',
-		},
-		height: {
-			type: 'string',
-			default: '600px',
-		},
-		width: {
-			type: 'string',
-			default: '100%',
-		},
-		isFullScreen: {
-			type: 'boolean',
-			default: false,
-		},
-	},
+	attributes,
 	supports: {
 		html: false,
 		align: true,

src/blocks/iframe/view.php

@@ -22,19 +22,17 @@ function newspack_blocks_render_block_iframe( $attributes ) {
  * Registers the `newspack-blocks/iframe` block on server.
  */
 function newspack_blocks_register_iframe() {
+	$block_json = json_decode(
+		file_get_contents( __DIR__ . '/block.json' ), // phpcs:ignore WordPress.WP.AlternativeFunctions.file_get_contents_file_get_contents
+		true
+	);
+
 	register_block_type(
-		'newspack-blocks/iframe',
-		array(
-			'attributes'      => array(
-				'src'           => array( 'type' => 'string' ),
-				'archiveFolder' => array( 'type' => 'string' ),
-				'height'        => array( 'type' => 'string' ),
-				'width'         => array( 'type' => 'string' ),
-				'isFullScreen'  => array( 'type' => 'boolean' ),
-			),
+		'newspack-blocks/' . $block_json['name'],
+		[
+			'attributes'      => $block_json['attributes'],
 			'render_callback' => 'newspack_blocks_render_block_iframe',
-			'supports'        => [],
-		)
+		]
 	);
 }
 add_action( 'init', 'newspack_blocks_register_iframe' );