Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Author List block to manifest of blocks to build in production #1011

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Jan 11, 2022

All Submissions:

Changes proposed in this Pull Request:

Adds the author-list block to the manifest of blocks to be built for production (block-list.json). Without it, automated build jobs won't include the new block. This wasn't caught previously because the watch command will include all block source files regardless of what's in the manifest.

How to test the changes in this Pull Request:

  1. On master, delete the dist folder (rm -r dist) and rebuild using npm run build.
  2. Observe that you can't add an Author List block to any post or page.
  3. Check out this branch, repeat step 1, confirm that you can now add the Author List block and view it on the front-end.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added the bug Something isn't working label Jan 11, 2022
@dkoo dkoo requested a review from a team January 11, 2022 18:28
@dkoo dkoo self-assigned this Jan 11, 2022
@dkoo dkoo merged commit abd5b7c into master Jan 11, 2022
@dkoo dkoo deleted the fix/add-author-list branch January 11, 2022 19:05
matticbot pushed a commit that referenced this pull request Jan 11, 2022
# [1.45.0-alpha.4](v1.45.0-alpha.3...v1.45.0-alpha.4) (2022-01-11)

### Bug Fixes

* add Author List block to manifest of blocks to build in production ([#1011](#1011)) ([abd5b7c](abd5b7c))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.45.0-alpha.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jan 19, 2022
# [1.45.0](v1.44.1...v1.45.0) (2022-01-19)

### Bug Fixes

* add Author List block to manifest of blocks to build in production ([#1011](#1011)) ([abd5b7c](abd5b7c))
* add simplified CSS class to carousel to reduce style size ([#983](#983)) ([f8b1b0a](f8b1b0a))
* **author-list:** user query when CAP is not installed ([#1015](#1015)) ([e798d9b](e798d9b))
* force alpha rebuild ([1e55132](1e55132))
* lint errors ([#1010](#1010)) ([c50a1f5](c50a1f5))
* re-add space between stacked columns ([#1022](#1022)) ([d560199](d560199))
* update columns styles for WordPress 5.9 ([#1020](#1020)) ([a38ce32](a38ce32))
* update Subscribe patterns for WordPress 5.9 ([#1017](#1017)) ([5cef283](5cef283))

### Features

* author list block ([#947](#947)) ([b98b8b8](b98b8b8))
* **donate-stripe:** hide fee checkbox if fees are zero ([#985](#985)) ([04e7892](04e7892))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants