Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(posts-query): specific posts getting #1090

Merged
merged 3 commits into from
Apr 7, 2022
Merged

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

#1083 re-instated issue fixed by #857. There's some confusion around "post type" attribute's casing in Newspack_Blocks::build_articles_query method – if post_type is supplied in the $attributes argument (instead of postType), it will be overridden with the default value (['post']).
This PR ensures that the call to the API always uses the camel-case postType (and not snake-cased post_type).

This confusion arises from the fact that postType is the block attribute, and post_type is the API call param.

How to test the changes in this Pull Request:

  1. Observe that the issue described in fix: show all saved post types in specific posts field #857 is reproducible on master
  2. Switch to this branch, observe the issue is not reproducible

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

adekbadek and others added 2 commits April 7, 2022 14:30
## [1.47.1-hotfix.1](v1.47.0...v1.47.1-hotfix.1) (2022-04-07)

### Bug Fixes

* **posts-query:** specific posts getting ([f9326db](f9326db))
@adekbadek adekbadek merged commit 231d62d into release Apr 7, 2022
@adekbadek adekbadek deleted the hotfix/specific-posts branch April 7, 2022 13:56
matticbot pushed a commit that referenced this pull request Apr 7, 2022
## [1.47.1](v1.47.0...v1.47.1) (2022-04-07)

### Bug Fixes

* **posts-query:** specific posts getting ([#1090](#1090)) ([231d62d](231d62d))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.47.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants