fix(posts-query): specific posts getting #1090
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
#1083 re-instated issue fixed by #857. There's some confusion around "post type" attribute's casing in
Newspack_Blocks::build_articles_query
method – ifpost_type
is supplied in the$attributes
argument (instead ofpostType
), it will be overridden with the default value (['post']
).This PR ensures that the call to the API always uses the camel-case
postType
(and not snake-casedpost_type
).This confusion arises from the fact that
postType
is the block attribute, andpost_type
is the API call param.How to test the changes in this Pull Request:
master
Other information: