Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columns Block: Column spacing wrong in editor and on front-end #1128

Closed
laurelfulford opened this issue May 3, 2022 · 3 comments · Fixed by #1133
Closed

Columns Block: Column spacing wrong in editor and on front-end #1128

laurelfulford opened this issue May 3, 2022 · 3 comments · Fixed by #1133

Comments

@laurelfulford
Copy link
Contributor

laurelfulford commented May 3, 2022

Describe the bug
As of WordPress 6.0, the column spacing in the editor and on the front-end does not look correct.

In the editor, it's too narrow; on the front-end, it's excessively wide.

The block has a gap of 0.5em defined; this is the only thing applied in the editor, and on the front-end, both it and the current margins are applied together.

This may need to be fixed in the Newspack Blocks repo, since we override the Columns styles there. [Update: I've moved the issue to the block repo as this seems pretty certain]. I also have an issue there for testing whether we can remove our custom styles that could be worth looking into specifically for this: #1065

@laurelfulford laurelfulford transferred this issue from Automattic/newspack-theme May 5, 2022
@laurelfulford laurelfulford self-assigned this May 5, 2022
@laurelfulford
Copy link
Contributor Author

The 'border' styles for the Columns block are also a little misaligned in WP 6.0 -- the border sits more to the left than right due to the gap value:
image

@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.52.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.52.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants