Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(donate): refresh reader authentication #1236

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

miguelpeixe
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Refresh reader authentication state on donation.

How to test the changes in this Pull Request:

  1. Check out this branch and feat: authenticated reader cookie newspack-plugin#1882
  2. On a new session with reader activation, donate using an already registered email
  3. Observe the "Sign In" is changed to "My Account"
  4. Click on "My Account" and confirm you're prompted to finish signing in
  5. Start a new session and donate using a new email
  6. Observe the "Sign In" is changed to "My Account"
  7. Click and confirm you are redirected to the "My Account" page

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@miguelpeixe miguelpeixe merged commit f21904b into master Aug 12, 2022
@miguelpeixe miguelpeixe deleted the feat/donate-block-refresh-reader-auth branch August 12, 2022 17:01
matticbot pushed a commit that referenced this pull request Aug 12, 2022
# [1.56.0-alpha.2](v1.56.0-alpha.1...v1.56.0-alpha.2) (2022-08-12)

### Bug Fixes

* ensure amount is always defined for totalAmount calculation ([#1227](#1227)) ([b1910dc](b1910dc))

### Features

* **donate:** refresh reader authentication ([#1236](#1236)) ([f21904b](f21904b))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.56.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Aug 12, 2022
# [1.56.0-alpha.2](v1.56.0-alpha.1...v1.56.0-alpha.2) (2022-08-12)

### Bug Fixes

* ensure amount is always defined for totalAmount calculation ([#1227](#1227)) ([b1910dc](b1910dc))
* resolve merge conflicts with [#1234](#1234) ([15fe247](15fe247))

### Features

* **donate:** refresh reader authentication ([#1236](#1236)) ([f21904b](f21904b))
matticbot pushed a commit that referenced this pull request Aug 16, 2022
# [1.56.0](v1.55.0...v1.56.0) (2022-08-16)

### Bug Fixes

* ensure amount is always defined for totalAmount calculation ([#1227](#1227)) ([b1910dc](b1910dc))
* force a new alpha build ([8bf60a8](8bf60a8))
* merge conflicts and force new build again ([b9020c6](b9020c6))
* resolve merge conflicts with [#1234](#1234) ([15fe247](15fe247))

### Features

* **donate:** add current_page_url to client metadata ([32e18a4](32e18a4))
* **donate:** customise donate button texts ([#1219](#1219)) ([8bda0f0](8bda0f0))
* **donate:** mobile style; UX tweaks ([#1201](#1201)) ([65a1285](65a1285))
* **donate:** refresh reader authentication ([#1236](#1236)) ([f21904b](f21904b))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.56.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants