Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct Donate thank you message alignment #1258

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

In the latest release of the Newspack Blocks, the thank you message is sitting beside the Donate Block button instead of above it, and some styles from the theme are causing an odd vertical alignment.

This PR switches the Thank You message from display: inline to display: block, to stack it above the button again.

Closes #1257

How to test the changes in this Pull Request:

  1. Add the Donate Block to a page and publish.
  2. View on the front end and note that the thank you message is next to the button, and weirdly aligned (in the editor the vertical alignment is a bit better, but the placement is different than in the 1.55 release:

image

  1. Apply the PR and run npm run build.
  2. Confirm that the thank you message is now above the donate block button:

image

  1. Cycle through the different Donate Block styles and confirm that no display issues are introduced.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford
Copy link
Contributor Author

Thanks @adekbadek!

@laurelfulford laurelfulford merged commit e838e61 into master Aug 29, 2022
@laurelfulford laurelfulford deleted the fix/donate-block-text-alignment branch August 29, 2022 15:46
matticbot pushed a commit that referenced this pull request Sep 6, 2022
# [1.57.0-alpha.2](v1.57.0-alpha.1...v1.57.0-alpha.2) (2022-09-06)

### Bug Fixes

* correct Donate thank you message alignment ([#1258](#1258)) ([e838e61](e838e61))
* update Homepage Posts grid spacing and add control  ([#1245](#1245)) ([9fa6972](9fa6972))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.57.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Sep 14, 2022
# [1.57.0](v1.56.0...v1.57.0) (2022-09-14)

### Bug Fixes

* add button block class to the Homepage Posts more button ([#1252](#1252)) ([c4d565c](c4d565c))
* correct Donate thank you message alignment ([#1258](#1258)) ([e838e61](e838e61))
* disambiguate users and guest authors in Author List exclusions ([#1154](#1154)) ([c59056b](c59056b))
* **donate:** default value not below minimum donation ([#1248](#1248)) ([368e856](368e856))
* **donate:** use first & last name as default name ([#1255](#1255)) ([105d95b](105d95b))
* re-add excerpt length preview in editor ([#1247](#1247)) ([bdbe86e](bdbe86e))
* update Homepage Posts grid spacing and add control  ([#1245](#1245)) ([9fa6972](9fa6972))

### Features

* handle minimum donation option in Donate block ([#1239](#1239)) ([10dfefe](10dfefe))
* if donation via a prompt, add prompt ID to Stripe payment metadata ([#1253](#1253)) ([b8cb0e9](b8cb0e9))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.57.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Donate Block: 'Thank you' and button alignment issues
3 participants