Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group Block style: Add border option to group block #463

Merged
merged 1 commit into from
May 17, 2020
Merged

Group Block style: Add border option to group block #463

merged 1 commit into from
May 17, 2020

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR adds a border style to the group block, a request that's come up a couple times.

It will need to be paired with border-related styles in the theme as well, to make sure some of the child themes (specifically, Nelson, Katharine and Joseph) are using their border styles on this block, too.

Closes #195.

How to test the changes in this Pull Request:

  1. Apply the PR and run npm run build.
  2. In the editor, add a group block, and confirm there is a 'borders' style. Apply it to your block:

image

  1. View in the editor, and confirm a border has been added, as well as padding (it's equal to how much padding is added when you add a background colour to that block):

image

  1. View on the front-end and confirm the border has been added:

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford mentioned this pull request May 6, 2020
Merged
6 tasks
@jeffersonrabb jeffersonrabb self-requested a review May 17, 2020 14:50
jeffersonrabb
jeffersonrabb approved these changes May 17, 2020
View reviewed changes
Copy link
Contributor

@jeffersonrabb jeffersonrabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@laurelfulford
Copy link
Contributor Author

Thanks Jeff!

@laurelfulford laurelfulford merged commit 1c1f89d into master May 17, 2020
@laurelfulford laurelfulford deleted the adds/group-block-border-style branch May 17, 2020 17:55
matticbot pushed a commit that referenced this pull request May 19, 2020
@semantic-release-bot
chore(release): 1.6.0 [skip ci]
a82108d 
# [1.6.0](v1.5.0...v1.6.0) (2020-05-19)

### Bug Fixes

* decode entities in categories when shown ([#474](#474)) ([5347ba3](5347ba3))
* decode entities in categories when shown in carousel ([#475](#475)) ([20dcfd3](20dcfd3))
* disallow 0 as post to show value ([80db497](80db497))
* initializing swiper for multiple blocks ([#476](#476)) ([f480d54](f480d54))

### Features

* add border style to group block ([#463](#463)) ([1c1f89d](1c1f89d))
* add image shape classes to the front end ([#473](#473)) ([c90df2e](c90df2e))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffersonrabb jeffersonrabb jeffersonrabb approved these changes

Assignees
No one assigned
Labels
released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Group Block: add 'border' style option
3 participants
@laurelfulford @matticbot @jeffersonrabb