Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog Posts Block: Add option for manual Continue Reading link #495

Closed
tijosh opened this issue May 26, 2020 · 6 comments · Fixed by #656
Closed

Blog Posts Block: Add option for manual Continue Reading link #495

tijosh opened this issue May 26, 2020 · 6 comments · Fixed by #656

Comments

@tijosh
Copy link

tijosh commented May 26, 2020

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Users cannot currently:

  1. Display a Continue Reading link and
  2. Control what comes before the link

If you set a manual excerpt or put a More block into the posts, no Continue Reading link is shown.

Describe the solution you'd like

Add option to manually include a Continue Reading button

Context

#21404141-hc

@laurelfulford
Copy link
Contributor

Just noting for anyone looking into this:

The 'Continue Reading' link will be coming from the theme, rather than the block. There are a number of themes that replace the [...] at the end of automatically generated excerpts with something else by filtering excerpt_more (example). The reason the link doesn't happen with Custom Excerpts is that the [...] is not there, since it's assumed that those would end with a full stop and not need an ellipsis.

If we added this enhancement, we might want this to fully replace the [...] for automatically generated excerpts (so theme filters won't interfere with it), and have the option to always include a customizable link at the end of the excerpt to the full post.

@tijosh
Copy link
Author

tijosh commented May 26, 2020

and have the option to always include a customizable link at the end of the excerpt to the full post.

I think this would be helpful. It allows consistency no matter how the posts are constructed.

@dcoleonline
Copy link

Also requested in 3264365-zen, so if this is ever added, we should notify them.

@mikeicode
Copy link

Requested 26351581-hc

@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.18.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.18.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants