Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel Title color is hard to read #548

Closed
supernovia opened this issue Jul 20, 2020 · 8 comments · Fixed by #553
Closed

Carousel Title color is hard to read #548

supernovia opened this issue Jul 20, 2020 · 8 comments · Fixed by #553

Comments

@supernovia
Copy link

Describe the bug
Carousel inherits title link color, but always displays a dark background. If the link color is dark, it makes things hard to see.
I am noticing this in two different themes so far. It seems to depend on the link color, and whether the title links have an explicit color set.

From Publisher Two:
Screen Shot 2020-07-20 at 5 10 27 PM

From Stratford:
Screen Shot 2020-07-20 at 5 18 32 PM

To Reproduce
Steps to reproduce the behavior:

  1. Add a Post Carousel block
  2. Choose a theme with dark title colors

Screenshots
See above

Expected behavior
Have sufficient contrast between background and text, or allow users to customize block colors, re: #382

@supernovia
Copy link
Author

@supernovia supernovia added [Block] Carousel a11y bug Something isn't working labels Jul 20, 2020
@supernovia
Copy link
Author

@iamtakashi do you know if there's someone we can ping about this? I'm not sure why we're getting dark text on a dark background. Asking only because I saw you were pinged in the other post, and because I know you're pretty awesome 🥇

@iamtakashi
Copy link

@supernovia Thanks for the ping! I had a quick look and was able to replicate the issue. I think the CSS for the block needs to be improved to avoid the issue.

I think that @thomasguillot is on a leave now, maybe @laurelfulford could help?

@laurelfulford
Copy link
Contributor

Thanks for the ping! I made some tweaks in #553 that seem to fix for Stratford & IP2 -- there's a chance we'll need to adjust again if there's a theme out there with super specific styles that override even this fix, but we'll cross that bridge when we get to it :)

@supernovia
Copy link
Author

Thank you!

@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.10.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@macmanx2
Copy link

Hm, this doesn't appear to be fixed yet for https://perigousse.wordpress.com/ @laurelfulford as noted at https://wordpress.com/forums/topic/font-color-post-carousel/#post-3548513

image-19

Any though as to what's going on there?

@macmanx2 macmanx2 reopened this Aug 21, 2020
@adekbadek
Copy link
Member

Changes in this repository are synchronised to wordpress.com pretty infrequently – by now they should have been synchronised and the issue resolved. If this is not the case, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants