Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure colors aren't overridden in non-NP themes #553

Merged
merged 1 commit into from
Jul 30, 2020
Merged

fix: make sure colors aren't overridden in non-NP themes #553

merged 1 commit into from
Jul 30, 2020

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

The Post Carousel block's font colours are largely set to inherit; in a couple WP.com themes, the carousel is inheriting from the theme's more specific styles, rather than the block, making the colours too dark. This PR switches the block to use #fff to fix. It's possible it won't fix all themes, but we can adjust further as individual cases crop up!

Note: this needs a WP.com sandbox to test.

Closes #548

How to test the changes in this Pull Request:

  1. On your WP.com sandbox, switch to a theme where this issue happens, like Stratford or Independent Publisher 2.
  2. Add a Post Carousel block to a page and publish.
  3. Note the issue on the front-end:

image

  1. Apply the PR and run npm run build
  2. Sync your local dev site with your WP.com sandbox using the process for the FSE plugin in Calypso (just ping me if you need steps!)
  3. Refresh your test post; the text should now be white:

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford mentioned this pull request Jul 23, 2020
Closed
adekbadek
adekbadek approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@laurelfulford
Copy link
Contributor Author

Thanks!

@laurelfulford laurelfulford merged commit 4b246fe into master Jul 30, 2020
@laurelfulford laurelfulford deleted the fix/548-carousel-contrast branch July 30, 2020 16:41
matticbot pushed a commit that referenced this pull request Aug 4, 2020
@semantic-release-bot
chore(release): 1.10.1 [skip ci]
ced31ea 
## [1.10.1](v1.10.0...v1.10.1) (2020-08-04)

### Bug Fixes

* make sure Post Carousel text colors aren't overridden ([#553](#553)) ([4b246fe](4b246fe))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.10.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adekbadek adekbadek adekbadek approved these changes

Assignees
No one assigned
Labels
released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Carousel Title color is hard to read
3 participants
@laurelfulford @matticbot @adekbadek