fix(homepage-posts): post fetch for widget blocks #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelpeixe
commented
Mar 11, 2022
| @@ -173,7 +173,8 @@ export const postsBlockSelector = ( select, { clientId, attributes } ) => { | |||
| const { getBlocks } = select( 'core/block-editor' ); | |||
| const editorBlocksIds = getEditorBlocksIds( getEditorBlocks() ); | |||
There was a problem hiding this comment.
getEditorBlocks() returns an empty array while in the widget editor, that's why another method for detecting the widget editor is used below.
6 tasks
matticbot
pushed a commit
that referenced
this pull request
Mar 31, 2022
# [1.47.0-alpha.1](v1.46.1...v1.47.0-alpha.1) (2022-03-31) ### Bug Fixes * **author-list:** handle alphabetizing last names containing spaces ([#1057](#1057)) ([1af7e19](1af7e19)) * authors and guest authors in homepage posts ([#1083](#1083)) ([038d9a4](038d9a4)) * donate block non-default styles grid breakpoint ([#1078](#1078)) ([5450e57](5450e57)) * **homepage-posts:** post fetch for widget blocks ([#1066](#1066)) ([3734a3f](3734a3f)) ### Features * add alternate and minimal styles to donate block ([#1068](#1068)) ([3c914d2](3c914d2))
|
🎉 This PR is included in version 1.47.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Apr 5, 2022
# [1.47.0](v1.46.1...v1.47.0) (2022-04-05) ### Bug Fixes * **author-list:** handle alphabetizing last names containing spaces ([#1057](#1057)) ([1af7e19](1af7e19)) * authors and guest authors in homepage posts ([#1083](#1083)) ([038d9a4](038d9a4)) * donate block non-default styles grid breakpoint ([#1078](#1078)) ([5450e57](5450e57)) * **homepage-posts:** post fetch for widget blocks ([#1066](#1066)) ([3734a3f](3734a3f)) * incorrect nesting of tax_query args ([#1087](#1087)) ([a613874](a613874)) ### Features * add alternate and minimal styles to donate block ([#1068](#1068)) ([3c914d2](3c914d2))
|
🎉 This PR is included in version 1.47.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
While adding a Homepage Posts or Carousel block to a widget area through the new block-based UI you get placeholder content instead of fetching actual posts.
This PR makes the necessary changes for these blocks to perform the posts fetch on the widget editor.
How to test the changes in this Pull Request:
npm run buildand confirm the posts are fetchedOther information: