Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: donate block non-default styles grid breakpoint #1078

Merged
merged 2 commits into from
Mar 28, 2022

Conversation

thomasguillot
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR changes the Tiers Grid breakpoints for the Alternate and Minimal styles.

See #1077

How to test the changes in this Pull Request:

  1. Add 2 donate blocks on a page, 1 with Alternate style, 1 with Minimal style
  2. Resize your screen
  3. Switch to this branch
  4. Refresh page

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the new styles and how compact they get at smaller viewports.

Non-blocking suggestion: I'd suggest that the Alternate and Minimal styles could also keep all four tier options in a single row, like the Default style. Currently the Default style is actually the most compact of the three styles because of this. Example:

Screen Shot 2022-03-24 at 3 05 52 PM

Screen Shot 2022-03-24 at 3 03 47 PM

@thomasguillot
Copy link
Contributor Author

Thank you for this @dkoo. I followed your advice and updated the breakpoints/grid: 4e8491e

Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good and even more compact:

Screen Shot 2022-03-28 at 10 03 59 AM

@thomasguillot thomasguillot merged commit 5450e57 into master Mar 28, 2022
@thomasguillot thomasguillot deleted the fix/donate-style-grid branch March 28, 2022 16:11
matticbot pushed a commit that referenced this pull request Mar 31, 2022
# [1.47.0-alpha.1](v1.46.1...v1.47.0-alpha.1) (2022-03-31)

### Bug Fixes

* **author-list:** handle alphabetizing last names containing spaces ([#1057](#1057)) ([1af7e19](1af7e19))
* authors and guest authors in homepage posts ([#1083](#1083)) ([038d9a4](038d9a4))
* donate block non-default styles grid breakpoint ([#1078](#1078)) ([5450e57](5450e57))
* **homepage-posts:** post fetch for widget blocks ([#1066](#1066)) ([3734a3f](3734a3f))

### Features

* add alternate and minimal styles to donate block ([#1068](#1068)) ([3c914d2](3c914d2))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.47.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Apr 5, 2022
# [1.47.0](v1.46.1...v1.47.0) (2022-04-05)

### Bug Fixes

* **author-list:** handle alphabetizing last names containing spaces ([#1057](#1057)) ([1af7e19](1af7e19))
* authors and guest authors in homepage posts ([#1083](#1083)) ([038d9a4](038d9a4))
* donate block non-default styles grid breakpoint ([#1078](#1078)) ([5450e57](5450e57))
* **homepage-posts:** post fetch for widget blocks ([#1066](#1066)) ([3734a3f](3734a3f))
* incorrect nesting of tax_query args ([#1087](#1087)) ([a613874](a613874))

### Features

* add alternate and minimal styles to donate block ([#1068](#1068)) ([3c914d2](3c914d2))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.47.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants