Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks: Unregister Jetpack's Donation Form block #1163

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

laurelfulford
Copy link
Contributor

@laurelfulford laurelfulford commented Jun 8, 2022

All Submissions:

Changes proposed in this Pull Request:

This PR unregisters the Jetpack Donations block, so it's not so easily confused with the Newspack Donate block.

Closes #1161.

How to test the changes in this Pull Request:

  1. Start on a test site running either a Jetpack Security or Jetpack Complete plan active (please ping me if you don't already have this plan and I can help!).
  2. Type /donate into the editor and note the blocks that appear:

image

  1. Apply the PR and run npm run build.
  2. Repeat step 2 and confirm that the 'Donations Form' block no longer appears in the list.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works! 👍

Also tested on a site without a Jetpack plan, and it doesn't cause any issues there.

@laurelfulford
Copy link
Contributor Author

Thanks @dkoo!

Also tested on a site without a Jetpack plan, and it doesn't cause any issues there.

Oh, that's an awesome double-check -- thanks!

@laurelfulford laurelfulford merged commit 6acbcac into master Jun 10, 2022
@laurelfulford laurelfulford deleted the fix/1161-remove-donate-block branch June 10, 2022 21:16
matticbot pushed a commit that referenced this pull request Jun 16, 2022
# [1.53.0-alpha.1](v1.52.0...v1.53.0-alpha.1) (2022-06-16)

### Bug Fixes

* **donate:** amount formatting ([c766ce3](c766ce3))
* **homepage posts block:** align items when an odd number of items is inserted ([#1173](#1173)) ([7139567](7139567))
* **iframe-block:** handle errors from server-side fetch ([#1162](#1162)) ([8378b41](8378b41))
* make sure block exists before unregistering ([#1169](#1169)) ([6d3deed](6d3deed))

### Features

* unregister the Jetpack Donation block ([#1163](#1163)) ([6acbcac](6acbcac))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.53.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jun 27, 2022
# [1.53.0](v1.52.0...v1.53.0) (2022-06-27)

### Bug Fixes

* **donate:** amount formatting ([c766ce3](c766ce3))
* **homepage posts block:** align items when an odd number of items is inserted ([#1173](#1173)) ([7139567](7139567))
* **iframe-block:** handle errors from server-side fetch ([#1162](#1162)) ([8378b41](8378b41))
* make sure block exists before unregistering ([#1169](#1169)) ([6d3deed](6d3deed))

### Features

* unregister the Jetpack Donation block ([#1163](#1163)) ([6acbcac](6acbcac))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.53.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blocks: Hide the Donation Form block
3 participants