Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make load more button styles more specific #527

Merged
merged 2 commits into from
Jun 30, 2020

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR makes the margin styles for the load more button a bit more specific, making sure they're a direct child of the main block wrapper, so they don't accidentally get picked up by sharing buttons on atomic sites. The LinkedIn button specifically is picking it up, and the share buttons are added inside of each article.

Closes #508.

How to test the changes in this Pull Request:

  1. Set up a homepage posts block and turn on the load more button.
  2. Apply the PR and run npm run build.
  3. View on the front-end and confirm that the 1em top margin is still being applied:

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@jeffersonrabb jeffersonrabb self-requested a review June 30, 2020 19:51
@jeffersonrabb jeffersonrabb merged commit 68089aa into master Jun 30, 2020
@jeffersonrabb jeffersonrabb deleted the fixes/button-styles branch June 30, 2020 19:57
matticbot pushed a commit that referenced this pull request Jun 30, 2020
# [1.9.0](v1.8.1...v1.9.0) (2020-06-30)

### Bug Fixes

* make load more button styles more specific ([#527](#527)) ([68089aa](68089aa))
* php warnings, phpcs warnings ([#540](#540)) ([23b34a1](23b34a1))

### Features

* editable donate button text ([#535](#535)) ([6261e3f](6261e3f))
* exclude current post in homepage posts block ([#539](#539)) ([030024d](030024d))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blog Posts block: gap/height issue affecting several elements
3 participants