Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(homepage posts): fix inconsistent column sizing when border enabled #827

Merged
merged 1 commit into from
Aug 10, 2021
Merged

fix(homepage posts): fix inconsistent column sizing when border enabled #827

merged 1 commit into from
Aug 10, 2021

Conversation

kariae
Copy link
Contributor

@kariae kariae commented Aug 4, 2021

All Submissions:

Changes proposed in this Pull Request:

Closes #825.

How to test the changes in this Pull Request:

  1. Open a new page.
  2. Add Homepage Post Block.
  3. Set Styles > Borders.
  4. Set to Grid View.
  5. Show media behind.
  6. Observe the column height is the same for all columns.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

laurelfulford
laurelfulford approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kariae! This looks good to me 👍

@kariae
Copy link
Contributor Author

kariae commented Aug 5, 2021

Thank you @laurelfulford

@kariae kariae merged commit 361fed5 into master Aug 10, 2021
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.33.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.33.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurelfulford laurelfulford laurelfulford approved these changes

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Homepage Post: Inconsistent Column Sizing when Border Enabled
3 participants
@kariae @matticbot @laurelfulford