fix: apply ex-donor status only if user has no active subscriptions #2101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoo
added
[Status] Needs Review
adekbadek
approved these changes
Nov 1, 2022
github-actions
bot
added
[Status] Approved
matticbot
pushed a commit
that referenced
this pull request
Nov 3, 2022
# [1.96.0-alpha.1](v1.95.2...v1.96.0-alpha.1) (2022-11-03) ### Bug Fixes * allow Stripe Billing portal to render without RAS ([b6e22cd](b6e22cd)) * apply ex-donor status only if user has no active subscriptions ([#2101](#2101)) ([40399ea](40399ea)) * apply My Account template changes only when RAS is active ([cd7b304](cd7b304)) * **stripe:** handle failed invoice fatal error ([#2103](#2103)) ([f865428](f865428)) * use default terms text in reg block if no text defined ([#2078](#2078)) ([443c59c](443c59c)) ### Features * enable setting user custom fields for job title etc. ([#2102](#2102)) ([4018af6](4018af6)), closes [#1723](#1723) * **newsletter-contact:** disallow overriding membership status field ([#2093](#2093)) ([8b8e134](8b8e134))
|
🎉 This PR is included in version 1.96.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Nov 14, 2022
# [1.96.0](v1.95.4...v1.96.0) (2022-11-14) ### Bug Fixes * allow Stripe Billing portal to render without RAS ([b6e22cd](b6e22cd)) * apply ex-donor status only if user has no active subscriptions ([#2101](#2101)) ([40399ea](40399ea)) * apply My Account template changes only when RAS is active ([cd7b304](cd7b304)) * package lock ([8707e53](8707e53)) * **stripe:** handle failed invoice fatal error ([#2103](#2103)) ([f865428](f865428)) * **Stripe:** improve handling of invoice error ([#2117](#2117)) ([609bf7d](609bf7d)) * update newspack-scripts to fix CI builds ([#2109](#2109)) ([ec1ee7a](ec1ee7a)) * use default terms text in reg block if no text defined ([#2078](#2078)) ([443c59c](443c59c)) ### Features * enable setting user custom fields for job title etc. ([#2102](#2102)) ([4018af6](4018af6)), closes [#1723](#1723) * **newsletter-contact:** disallow overriding membership status field ([#2093](#2093)) ([8b8e134](8b8e134))
|
🎉 This PR is included in version 1.96.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Currently, if a reader cancels a recurring Stripe subscription, their donor status in the
NP_Membership Statuscustom field is updated to "Ex-" donor. However, it's possible for readers to have multiple active recurring subscriptions, so cancelling one while keeping others active should not apply the "ex-donor" status. A contact should be considered an ex-donor only if they've canceled donations and have no currently active donations.How to test the changes in this Pull Request:
NP_Membership Statuslike "Monthly Donor" depending on the frequency of the donation.NP_Current Subscription End Dateis updated with the date of the cancellation, but that theNP_Membership Statusvalue is still "Monthly Donor" (or matching the frequency of the most recently created recurring donation).NP_Current Subscription End Dateis updated with the date of the latest cancellation, and that theNP_Membership Statusvalue is now "Ex-Monthly Donor", since the contact has cancelled all known subscriptions.Other information: