Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Width issue with column blocks + background colours #840

Closed
laurelfulford opened this issue Mar 19, 2020 · 1 comment
Closed

Width issue with column blocks + background colours #840

laurelfulford opened this issue Mar 19, 2020 · 1 comment
Assignees
@laurelfulford
Labels
[Status] Has pull request [Type] Bug Incorrect behavior or functionality

Comments

@laurelfulford
Copy link
Contributor

This may need to be fixed in the theme, or it may need to be fixed in the Column styles we have in the Newspack blocks:

image

When you add a background colour to the columns block, it highlights the fact the block has a negative margin on the left and right, as it pulls it 16px out on each side:
@laurelfulford laurelfulford added the [Type] Bug Incorrect behavior or functionality label Mar 19, 2020
@laurelfulford laurelfulford mentioned this issue May 12, 2022
Merged
6 tasks
@laurelfulford
Copy link
Contributor Author

Closed with Automattic/newspack-blocks#1133 and #1801.

@laurelfulford laurelfulford self-assigned this May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurelfulford laurelfulford

Labels
[Status] Has pull request [Type] Bug Incorrect behavior or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laurelfulford