Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom style to subscribe patterns #1760

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Add custom style to subscribe patterns #1760

merged 2 commits into from
Apr 8, 2022

Conversation

thomasguillot
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR adds specific custom styles to some new patterns I added to Newspack Blocks (Automattic/newspack-blocks#1091).

Note: These patterns are meant for an Overlay and not an Inline so I didn't add specific CSS for Inline (will do in a separate PR)

7
8
9

How to test the changes in this Pull Request:

  1. Switch to this branch
  2. Create an Overlay Prompt
  3. Insert Pattern > Subscribe 7/8/9
  4. Preview

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@thomasguillot thomasguillot added the [Status] Needs Review The issue or pull request needs to be reviewed label Apr 7, 2022
@thomasguillot thomasguillot requested a review from a team as a code owner April 7, 2022 16:16
@thomasguillot
Copy link
Contributor Author

I have an issue with lint... when I run npm run format:scss I get prettier: command not found

@laurelfulford
Copy link
Contributor

@thomasguillot I can't recreate the issue with lint; it works for me, but also at times I feel like those kinds of things only work on my computer based on luck and which direction the wind is blowing 😐

Let me know if it would help if I ran npm run format:scss locally on this PR and pushed up any changes!

@thomasguillot
Copy link
Contributor Author

Managed to fix the lint issue (0eec23e). I had to reinstall prettier for some reason npm i prettier 🤔

laurelfulford
laurelfulford approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these new styles (and patterns!) look good! 🚢

I tested with a variety of overlay placements and sizes, at different breakpoints. While there were some understandable clashes (#7 and 'small' campaign sizes, for example, don't mix), they previewed accurately in the editor, which should guide people to make good decisions about the options like this that they can change.

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Apr 8, 2022
@thomasguillot thomasguillot merged commit 83a836e into master Apr 8, 2022
@thomasguillot thomasguillot deleted the add/subscribe-patterns-style branch April 8, 2022 08:25
matticbot pushed a commit that referenced this pull request May 2, 2022
@semantic-release-bot
chore(release): 1.58.0-alpha.1 [skip ci]
d676253 
# [1.58.0-alpha.1](v1.57.2...v1.58.0-alpha.1) (2022-05-02)

### Bug Fixes

* correct margin issue in editor with floated images ([#1781](#1781)) ([cf4e008](cf4e008))
* make sure captions and credits inherit colours ([#1775](#1775)) ([302b2e3](302b2e3))
* make sure links remain white in the carousel block ([#1778](#1778)) ([88f20e9](88f20e9))
* remove unneeded featured image content option ([#1776](#1776)) ([1afddcf](1afddcf))

### Features

* add custom style to subscribe patterns ([#1760](#1760)) ([83a836e](83a836e))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.58.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request May 3, 2022
@semantic-release-bot
chore(release): 1.58.0 [skip ci]
8e46fe3 
# [1.58.0](v1.57.2...v1.58.0) (2022-05-03)

### Bug Fixes

* correct margin issue in editor with floated images ([#1781](#1781)) ([cf4e008](cf4e008))
* make sure captions and credits inherit colours ([#1775](#1775)) ([302b2e3](302b2e3))
* make sure links remain white in the carousel block ([#1778](#1778)) ([88f20e9](88f20e9))
* remove unneeded featured image content option ([#1776](#1776)) ([1afddcf](1afddcf))

### Features

* add custom style to subscribe patterns ([#1760](#1760)) ([83a836e](83a836e))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.58.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurelfulford laurelfulford laurelfulford approved these changes

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasguillot @laurelfulford @matticbot