Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make third level headings a unique size on mobile #1816

Merged
merged 1 commit into from
May 27, 2022
Merged

fix: make third level headings a unique size on mobile #1816

merged 1 commit into from
May 27, 2022

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Right now both the h2 and h3 are the same size on mobile screens.

This PR makes the h3 slightly smaller than the h2 on smaller screen sizes, while still being larger than the h4`. This lead to me adding a non-variable defined font size, but this seemed to be the most straight forward fix, that didn't involve renaming/reworking existing variables to squeeze another one into the naming convention.

Closes #1812

How to test the changes in this Pull Request:

  1. Edit a post and add an h2, h3, and h4.
  2. Publish and view the front end; shrink down the browser window and note the h2 and h3 display at the same size:

image

  1. Apply the PR and run npm run build.
  2. Confirm that the h3 now falls between the h2 and h4 in size on smaller screens:

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added the [Status] Needs Review The issue or pull request needs to be reviewed label May 25, 2022
@laurelfulford laurelfulford requested a review from a team as a code owner May 25, 2022 00:19
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels May 27, 2022
@laurelfulford
Copy link
Contributor Author

Thanks @adekbadek!

@laurelfulford laurelfulford merged commit 265a8a7 into master May 27, 2022
@laurelfulford laurelfulford deleted the fix/1812-header-sizes-mobile branch May 27, 2022 23:02
matticbot pushed a commit that referenced this pull request Jun 2, 2022
@semantic-release-bot
chore(release): 1.59.0-alpha.1 [skip ci]
c17920c 
# [1.59.0-alpha.1](v1.58.3...v1.59.0-alpha.1) (2022-06-02)

### Bug Fixes

* make third level headings a unique size on mobile ([#1816](#1816)) ([265a8a7](265a8a7))
* remove custom column block styles ([#1801](#1801)) ([56b9e84](56b9e84))
* remove incorrect hover effect from video block ([#1815](#1815)) ([dfa36c9](dfa36c9))

### Features

* add custom style to subscribe pattern 10 ([#1818](#1818)) ([da861bb](da861bb))
* add Trust Indicators job title to author bio ([#1806](#1806)) ([8af5709](8af5709))
* remove Aside post format support ([#1810](#1810)) ([7a9b213](7a9b213))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.59.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jun 13, 2022
@semantic-release-bot
chore(release): 1.59.0 [skip ci]
c9cf78b 
# [1.59.0](v1.58.3...v1.59.0) (2022-06-13)

### Bug Fixes

* make third level headings a unique size on mobile ([#1816](#1816)) ([265a8a7](265a8a7))
* remove custom column block styles ([#1801](#1801)) ([56b9e84](56b9e84))
* remove incorrect hover effect from video block ([#1815](#1815)) ([dfa36c9](dfa36c9))

### Features

* add custom style to subscribe pattern 10 ([#1818](#1818)) ([da861bb](da861bb))
* add Trust Indicators job title to author bio ([#1806](#1806)) ([8af5709](8af5709))
* remove Aside post format support ([#1810](#1810)) ([7a9b213](7a9b213))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.59.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adekbadek adekbadek adekbadek approved these changes

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header Size: H2 and H3 are the same on mobile
3 participants
@laurelfulford @matticbot @adekbadek