-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add downloads details to checkout #2162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well! 🙌
Non-blocking: if this template is copied from Woo, should we use wc_get_template()
instead?
E.g.:
<?php
$downloads = $order->get_downloadable_items();
if ( $downloads ) {
wc_get_template(
'order/order-downloads.php',
array(
'downloads' => $downloads,
'show_title' => true,
)
);
}
?>
Oh, that's a much better idea 🙂 Will make that update before merging! |
# [1.77.0-alpha.1](v1.76.0...v1.77.0-alpha.1) (2023-08-08) ### Bug Fixes * add padding to the file block when it has a background ([#2168](#2168)) ([5a29efa](5a29efa)) * improve new search setting appearance for WP 6.3 ([#2167](#2167)) ([a87f7e5](a87f7e5)) ### Features * add downloads details to checkout ([#2162](#2162)) ([81c52f5](81c52f5)) * add styles for the details block ([#2165](#2165)) ([25832c3](25832c3)) * add styles for the footnote block ([#2166](#2166)) ([22732f5](22732f5)) * add Threads logo to the social links menu ([#2158](#2158)) ([64bf6c1](64bf6c1))
🎉 This PR is included in version 1.77.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
# [1.77.0](v1.76.0...v1.77.0) (2023-08-08) ### Bug Fixes * add padding to the file block when it has a background ([#2168](#2168)) ([5a29efa](5a29efa)) * improve new search setting appearance for WP 6.3 ([#2167](#2167)) ([a87f7e5](a87f7e5)) ### Features * add downloads details to checkout ([#2162](#2162)) ([81c52f5](81c52f5)) * add styles for the details block ([#2165](#2165)) ([25832c3](25832c3)) * add styles for the footnote block ([#2166](#2166)) ([22732f5](22732f5)) * add Threads logo to the social links menu ([#2158](#2158)) ([64bf6c1](64bf6c1))
🎉 This PR is included in version 1.77.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
This PR adds the downloads table to the thank you screen in the WooCommerce checkout.
It's normally shown by default, but our simplified thankyou.php template removes the hooks where that and other information are normally inserted. So this PR re-adds it by adding a check for downloads, and then manually inserts what's normally the contents of the woocommerce/order/order-downloads.php template.
See 1200550061930446-as-1204781973711258
How to test the changes in this Pull Request:
npm run build
.Other information: