Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reading the progress data from the custom tables #7076

Closed
m1r0 opened this issue Aug 9, 2023 · 2 comments · Fixed by #7142
Closed

Allow reading the progress data from the custom tables #7076

m1r0 opened this issue Aug 9, 2023 · 2 comments · Fixed by #7142
Assignees
Labels
Milestone

Comments

@m1r0
Copy link
Member

m1r0 commented Aug 9, 2023

Goal

Currently, the progress repository is fetching the data from comments. The goal of this card is to start reading data from the tables once the data migration is done.

Scope

  • Enable the progress repository classes to read the data from the custom tables instead of the comments.
  • Create new cards if there are bugs.
@m1r0 m1r0 added the HPPS label Aug 9, 2023
@m1r0 m1r0 changed the title Integrate the new setting for reading the data from the custom tables Allow reading the progress data from the custom tables Aug 30, 2023
@merkushin merkushin self-assigned this Aug 31, 2023
@merkushin
Copy link
Member

I'm branching out from this PR to have fewer conflicts later: #7140

@merkushin
Copy link
Member

merkushin commented Aug 31, 2023

@m1r0

I was thinking about how to process two flags: use tables (feature enabled) and read from tables (the new one).

I realized that adding that reading from tables (and writing to comments) logic to the existing aggregate repository will make that repository too intricate.

The more straightforward solution is to add a new aggregate with all that logic.

The factory, looking at flags, decides which aggregate to create.

Here is the draft: fe266df

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants