Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for Psalm #7094

Closed
donnapep opened this issue Aug 14, 2023 · 0 comments
Closed

Add configuration for Psalm #7094

donnapep opened this issue Aug 14, 2023 · 0 comments
Assignees
Labels
[Pri] Normal Can wait for the next release [Type] Enhancement

Comments

@donnapep
Copy link
Collaborator

donnapep commented Aug 14, 2023

Is your feature request related to a problem? Please describe

There are gaps in Sensei’s test coverage and some code isn’t easily testable regardless. We would like to gain some quick code quality wins by adopting Psalm, a static code analysis tool.

Describe the solution you'd like

Add a configuration for Psalm such that it uses the least strict level, and only runs checks on code that has changed.

Describe alternatives you've considered

We also considered PHPStan and Phan, but Psalm seems to be used by other Automattic teams more.

Additional context

pdxWSz-15I-p2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal Can wait for the next release [Type] Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants