-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create tables-based versions of student progress and quiz data when saving of their comment based versions #7140
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #7140 +/- ##
============================================
+ Coverage 49.60% 49.68% +0.07%
- Complexity 10609 10623 +14
============================================
Files 580 580
Lines 44791 44876 +85
Branches 402 402
============================================
+ Hits 22220 22297 +77
- Misses 22244 22252 +8
Partials 327 327
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Looks solid overall but I found a few bugs:
mewF8k.mov |
It looks like we don't try to save it there, so I think it is out of scope. Or I miss something? I'm looking at the issue now and the task has a vague description. I think we discussed to create counterparts only on save. Or do you think, we should do it on get/has as well? That's possible, but might impair performance on the other hand.
Good catch, thank you. Fixed here: 5f6bb07 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we don't try to save it there, so I think it is out of scope.
After seeing that the course progress was created after grading the quiz, I've just assumed that the lesson progress should be created as well. But I agree, this is out of scope and also it might be unnecessary to do.
👍
Resolves #7078
Proposed Changes
Testing Instructions
tables_based_progress
).Pre-Merge Checklist