-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the "Dev" changelog section #6804
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #6804 +/- ##
============================================
+ Coverage 49.32% 49.33% +0.01%
- Complexity 10538 10539 +1
============================================
Files 575 575
Lines 44501 44503 +2
Branches 402 402
============================================
+ Hits 21950 21956 +6
+ Misses 22224 22220 -4
Partials 327 327
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
In a team meeting, we decided to tweak this PR to add more detailed descriptions of each change log option, and pair it with a P2 post to explain proper change log entry usage. |
I've updated the descriptions in 988184c. LMKWYT. 🙂 |
@donnapep I would like to know if the examples in the descriptions are making sense to you. If not, the future explainer P2 post might have to be in a more detailed format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Hope you don't mind, but I tweaked it slightly in f2583a2, and changed one of the descriptions to include template changes for the dev
option.
Looks even better, thanks! |
Proposed Changes
Testing Instructions
npm run changelog
.patch/minor/major
.dev
section.Pre-Merge Checklist