-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lesson loading error issue in learning mode for themes that are using referenced styles #7658
Conversation
Test the previous changes of this PR with WordPress Playground. |
Test the previous changes of this PR with WordPress Playground. |
Test the previous changes of this PR with WordPress Playground. |
Test the previous changes of this PR with WordPress Playground. |
…omattic/sensei into fix/passing-array-to-strncmp
Test the previous changes of this PR with WordPress Playground. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Imran92!
I reproduced the issue on trunk first, then confirmed the issue is fixed in this PR.
Two more incidents of this issue have been reported here #7659. |
Resolves #7659
8551277-zd-a8c
Proposed Changes
So to prevent the error, we've added a check to attempt extracting style only when the value is a string. For proper extraction we've created an issue here #7660 .
Testing Instructions
Pre-Merge Checklist