Remote: reassigned block patterns to default categories #5664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems fine! I think we still need to define those categories just in case the external call to the pattern directory doesn't work? Or at least, that's what we did in Twenty Twenty-Two. In addition to their more specific categories, we should also add these categories to the "featured" category too. |
MaggieCabrera
force-pushed
the
remote-patterns-categories
branch
from
c53ae05
to
414d71d
Compare
|
We need to re register the categories so the theme patterns show up first, but they work fine without doing so. I did it anyway, since it's what we did on archeo too. I wish there was a simpler way to reorder patterns though, feels like a lot of PHP just for that! I added all the patterns to the featured category too. |
|
I opened a GB issue about this: WordPress/gutenberg#39500 |
kjellr
approved these changes
Mar 18, 2022
MaggieCabrera
force-pushed
the
remote-patterns-categories
branch
from
691bbc9
to
a77f78e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Instead of using the pages category (blame copy paste when setting up the theme for that) I've assigned all patters to default categories for now. @kjellr @beafialho feel free to correct any that you think it's not the right one.