Archeo: Load patterns automatically #5715
Conversation
|
This will land in .com in 12.9 |
|
This is looking good! I just have minor comments, thanks for doing this |
# Conflicts: # archeo/inc/patterns/footer.php # archeo/inc/patterns/image-with-headline-description.php
|
I've removed inc/block-patterns.php and moved the code into functions.php, and then I've updated two patterns which have since been updated on trunk. I think this is ready for another review. |
There was a problem hiding this comment.
Very cool, working as advertised.
I did notice that some of the patterns load in a random order in the inserter, check out the Images category and notice how a couple Archeo patterns come first, followed by Gutenberg default patterns, then more Archeo patterns. Is there a way to have the theme's always appear first?
Co-authored-by: Jeff Ong <jonger4@gmail.com>
Oh yeah, I can see the same. It doesn't look like they're listed alphabetically, plus I tried adding numbers to the start of the Archeo pattern titles but it didn't seem to make a difference to the order. |
# Conflicts: # archeo/inc/patterns/simple-list-of-posts-with-background.php
|
Just spotted @MaggieCabrera has already opened up an issue to address the pattern order: WordPress/gutenberg#39500 I'm going to move this into Approved but not mergeable, as I think it's ready to go when 12.9 lands. |
Changes proposed in this Pull Request:
Loads the patterns for Archeo automatically based on https://github.com/WordPress/gutenberg/pull/36751/files
Related issue(s):
https://github.com/WordPress/gutenberg/pull/36751/files